[U-Boot] [PATCH] sf: Updated Makefile to group generic files

Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com --- drivers/mtd/spi/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a2..fd8f8a4 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,15 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-obj-$(CONFIG_CMD_SF) += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +ifdef CONFIG_CMD_SF +obj-y += sf.o +endif + +ifdef CONFIG_SPI_FLASH +obj-y += sf_probe.o +obj-y += sf_ops.o +endif + obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 10:57 AM, Jagannadha Sutradharudu Teki wrote:
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mtd/spi/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a2..fd8f8a4 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,15 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-obj-$(CONFIG_CMD_SF) += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +ifdef CONFIG_CMD_SF +obj-y += sf.o +endif
+ifdef CONFIG_SPI_FLASH +obj-y += sf_probe.o +obj-y += sf_ops.o +endif
obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o
OK, wait, what? What's being solved here? Thanks!
- -- Tom

On Thu, Dec 19, 2013 at 10:06 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 10:57 AM, Jagannadha Sutradharudu Teki wrote:
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mtd/spi/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a2..fd8f8a4 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,15 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-obj-$(CONFIG_CMD_SF) += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +ifdef CONFIG_CMD_SF +obj-y += sf.o +endif
+ifdef CONFIG_SPI_FLASH +obj-y += sf_probe.o +obj-y += sf_ops.o +endif
obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o
OK, wait, what? What's being solved here? Thanks!
Nothing solved- just group generic files one after another. Any mistake?

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 12:26 PM, Jagan Teki wrote:
On Thu, Dec 19, 2013 at 10:06 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 10:57 AM, Jagannadha Sutradharudu Teki wrote:
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mtd/spi/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a2..fd8f8a4 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,15 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-obj-$(CONFIG_CMD_SF) += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +ifdef CONFIG_CMD_SF +obj-y += sf.o +endif
+ifdef CONFIG_SPI_FLASH +obj-y += sf_probe.o +obj-y += sf_ops.o +endif
obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o
OK, wait, what? What's being solved here? Thanks!
Nothing solved- just group generic files one after another. Any mistake?
Well, it feels like a step backwards.
- -- Tom

On Thu, Dec 19, 2013 at 11:09 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 12:26 PM, Jagan Teki wrote:
On Thu, Dec 19, 2013 at 10:06 PM, Tom Rini trini@ti.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 12/19/2013 10:57 AM, Jagannadha Sutradharudu Teki wrote:
Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com Cc: Masahiro Yamada yamada.m@jp.panasonic.com
drivers/mtd/spi/Makefile | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/spi/Makefile b/drivers/mtd/spi/Makefile index 26483a2..fd8f8a4 100644 --- a/drivers/mtd/spi/Makefile +++ b/drivers/mtd/spi/Makefile @@ -10,8 +10,15 @@ obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o obj-$(CONFIG_SPL_SPI_BOOT) += fsl_espi_spl.o endif
-obj-$(CONFIG_CMD_SF) += sf.o -obj-$(CONFIG_SPI_FLASH) += sf_probe.o sf_ops.o +ifdef CONFIG_CMD_SF +obj-y += sf.o +endif
+ifdef CONFIG_SPI_FLASH +obj-y += sf_probe.o +obj-y += sf_ops.o +endif
obj-$(CONFIG_SPI_FRAM_RAMTRON) += ramtron.o obj-$(CONFIG_SPI_FLASH_SANDBOX) += sandbox.o obj-$(CONFIG_SPI_M95XXX) += eeprom_m95xxx.o
OK, wait, what? What's being solved here? Thanks!
Nothing solved- just group generic files one after another. Any mistake?
Well, it feels like a step backwards.
I saw the generic files are grouped same in drivers/mtd/nand/Makefile. Tried the same -may be this can also will fix - OK please ignore this.
participants (3)
-
Jagan Teki
-
Jagannadha Sutradharudu Teki
-
Tom Rini