[U-Boot] [PATCH] arm: socfpga: Remove bashisms from qts filter
Weed out bashisms from the script. The echo -e does not work in dash, which is the default /bin/sh in debian .
Signed-off-by: Marek Vasut marex@denx.de Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Chin Liang See clsee@altera.com Cc: Dalon Westergreen dwesterg@gmail.com --- arch/arm/mach-socfpga/qts-filter.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach-socfpga/qts-filter.sh index 1adfbf7..050d6ba 100755 --- a/arch/arm/mach-socfpga/qts-filter.sh +++ b/arch/arm/mach-socfpga/qts-filter.sh @@ -187,13 +187,13 @@ usage() { echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir] [output_dir]" echo "Process QTS-generated headers into U-Boot compatible ones." echo "" - echo -e " soc_type\t-\tType of SoC, either 'cyclone5' or 'arria5'." - echo -e " input_qts_dir\t-\tDirectory with compiled Quartus project" - echo -e "\t\t\t\tand containing the Quartus project file (QPF)." - echo -e " input_bsp_dir\t-\tDirectory with generated bsp containing" - echo -e "\t\t\t\tthe settings.bsp file." - echo -e " output_dir\t-\tDirectory to store the U-Boot compatible" - echo -e "\t\t\t\theaders." + echo " soc_type - Type of SoC, either 'cyclone5' or 'arria5'." + echo " input_qts_dir - Directory with compiled Quartus project" + echo " and containing the Quartus project file (QPF)." + echo " input_bsp_dir - Directory with generated bsp containing" + echo " the settings.bsp file." + echo " output_dir - Directory to store the U-Boot compatible" + echo " headers." echo "" }
On Thu, Feb 11, 2016 at 04:40:59PM +0100, Marek Vasut wrote:
Weed out bashisms from the script. The echo -e does not work in dash, which is the default /bin/sh in debian .
Signed-off-by: Marek Vasut marex@denx.de Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Chin Liang See clsee@altera.com Cc: Dalon Westergreen dwesterg@gmail.com
Reviewed-by: Tom Rini trini@konsulko.com
Dear Marek Vasut,
In message 1455205259-14263-1-git-send-email-marex@denx.de you wrote:
Weed out bashisms from the script. The echo -e does not work in dash, which is the default /bin/sh in debian .
Signed-off-by: Marek Vasut marex@denx.de Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Chin Liang See clsee@altera.com Cc: Dalon Westergreen dwesterg@gmail.com
arch/arm/mach-socfpga/qts-filter.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach-socfpga/qts-filter.sh index 1adfbf7..050d6ba 100755 --- a/arch/arm/mach-socfpga/qts-filter.sh +++ b/arch/arm/mach-socfpga/qts-filter.sh @@ -187,13 +187,13 @@ usage() { echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir] [output_dir]" echo "Process QTS-generated headers into U-Boot compatible ones." echo ""
- echo -e " soc_type\t-\tType of SoC, either 'cyclone5' or 'arria5'."
- echo -e " input_qts_dir\t-\tDirectory with compiled Quartus project"
- echo -e "\t\t\t\tand containing the Quartus project file (QPF)."
- echo -e " input_bsp_dir\t-\tDirectory with generated bsp containing"
- echo -e "\t\t\t\tthe settings.bsp file."
- echo -e " output_dir\t-\tDirectory to store the U-Boot compatible"
- echo -e "\t\t\t\theaders."
- echo " soc_type - Type of SoC, either 'cyclone5' or 'arria5'."
- echo " input_qts_dir - Directory with compiled Quartus project"
- echo " and containing the Quartus project file (QPF)."
- echo " input_bsp_dir - Directory with generated bsp containing"
- echo " the settings.bsp file."
- echo " output_dir - Directory to store the U-Boot compatible"
- echo " headers." echo ""
}
I always wonder why people go through the efforts to write such long sequences of echo commands.
Why don't you simply use a here document? It is much easier to provide correct formatting there, too.
Best regards,
Wolfgang Denk
On 02/14/2016 11:23 AM, Wolfgang Denk wrote:
Dear Marek Vasut,
In message 1455205259-14263-1-git-send-email-marex@denx.de you wrote:
Weed out bashisms from the script. The echo -e does not work in dash, which is the default /bin/sh in debian .
Signed-off-by: Marek Vasut marex@denx.de Cc: Dinh Nguyen dinguyen@opensource.altera.com Cc: Chin Liang See clsee@altera.com Cc: Dalon Westergreen dwesterg@gmail.com
arch/arm/mach-socfpga/qts-filter.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-socfpga/qts-filter.sh b/arch/arm/mach-socfpga/qts-filter.sh index 1adfbf7..050d6ba 100755 --- a/arch/arm/mach-socfpga/qts-filter.sh +++ b/arch/arm/mach-socfpga/qts-filter.sh @@ -187,13 +187,13 @@ usage() { echo "$0 [soc_type] [input_qts_dir] [input_bsp_dir] [output_dir]" echo "Process QTS-generated headers into U-Boot compatible ones." echo ""
- echo -e " soc_type\t-\tType of SoC, either 'cyclone5' or 'arria5'."
- echo -e " input_qts_dir\t-\tDirectory with compiled Quartus project"
- echo -e "\t\t\t\tand containing the Quartus project file (QPF)."
- echo -e " input_bsp_dir\t-\tDirectory with generated bsp containing"
- echo -e "\t\t\t\tthe settings.bsp file."
- echo -e " output_dir\t-\tDirectory to store the U-Boot compatible"
- echo -e "\t\t\t\theaders."
- echo " soc_type - Type of SoC, either 'cyclone5' or 'arria5'."
- echo " input_qts_dir - Directory with compiled Quartus project"
- echo " and containing the Quartus project file (QPF)."
- echo " input_bsp_dir - Directory with generated bsp containing"
- echo " the settings.bsp file."
- echo " output_dir - Directory to store the U-Boot compatible"
- echo " headers." echo ""
}
I always wonder why people go through the efforts to write such long sequences of echo commands.
Why don't you simply use a here document? It is much easier to provide correct formatting there, too.
The original help message was some one-liner, that's why.
Dear Marek,
In message 56C083E0.1000804@denx.de you wrote:
I always wonder why people go through the efforts to write such long sequences of echo commands.
Why don't you simply use a here document? It is much easier to provide correct formatting there, too.
The original help message was some one-liner, that's why.
That does not explain the issue. Of course "echo" is perfect for a single line, or two. But when someone writes 11 "echo" commands in sequence this is no longer reasonable.
Best regards,
Wolfgang Denk
On 02/14/2016 07:54 PM, Wolfgang Denk wrote:
Dear Marek,
In message 56C083E0.1000804@denx.de you wrote:
I always wonder why people go through the efforts to write such long sequences of echo commands.
Why don't you simply use a here document? It is much easier to provide correct formatting there, too.
The original help message was some one-liner, that's why.
That does not explain the issue. Of course "echo" is perfect for a single line, or two. But when someone writes 11 "echo" commands in sequence this is no longer reasonable.
There was originally one or two echo commands. Someone added more arguments, so there were now more echo commands. Patches are welcome to improve that.
participants (3)
-
Marek Vasut -
Tom Rini -
Wolfgang Denk