[U-Boot] "Move do_irqinfo() to common/cmd_irq.c" breaks MVBLUE board...
Dear Peter,
your commit c253122395 (Move do_irqinfo() to common/cmd_irq.c) breaks building of the MVBLUE board:
-> ./MAKEALL MVBLUE Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo' make: *** [u-boot] Error 1
Can you please have a look?
Best regards,
Wolfgang Denk
On Sun, 2009-12-06 at 00:06 +0100, Wolfgang Denk wrote:
Dear Peter,
your commit c253122395 (Move do_irqinfo() to common/cmd_irq.c) breaks building of the MVBLUE board:
-> ./MAKEALL MVBLUE Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo' make: *** [u-boot] Error 1
Can you please have a look?
Sure, sorry for the breakage. Looks like MVBLUE has CONFIG_CMD_IRQ defined, but doesn't have CONFIG_CMD_MISC defined. Prior to my move, since the do_irqinfo() was inside cmd_misc.c, the do_irqinfo() call was never compiled.
So previously, CONFIG_CMD_IRQ had no effect and was ignored for the MVBLUE.
cpu/mpc824x/interrupts.c doesn't have do_irqinfo() implemented, which causes the problem.
I'll send a patch which removes CONFIG_CMD_IRQ from MVBLUE.h as a fix.
Best, Peter
On Sat, 2009-12-05 at 17:43 -0600, Peter Tyser wrote:
On Sun, 2009-12-06 at 00:06 +0100, Wolfgang Denk wrote:
Dear Peter,
your commit c253122395 (Move do_irqinfo() to common/cmd_irq.c) breaks building of the MVBLUE board:
-> ./MAKEALL MVBLUE Configuring for MVBLUE board... common/libcommon.a(cmd_irq.o):(.u_boot_cmd+0x24): undefined reference to `do_irqinfo' make: *** [u-boot] Error 1
Can you please have a look?
Sure, sorry for the breakage. Looks like MVBLUE has CONFIG_CMD_IRQ defined, but doesn't have CONFIG_CMD_MISC defined. Prior to my move, since the do_irqinfo() was inside cmd_misc.c, the do_irqinfo() call was never compiled.
So previously, CONFIG_CMD_IRQ had no effect and was ignored for the MVBLUE.
cpu/mpc824x/interrupts.c doesn't have do_irqinfo() implemented, which causes the problem.
I'll send a patch which removes CONFIG_CMD_IRQ from MVBLUE.h as a fix.
On second thought, this will disable both the 'interrupts' and 'irqinfo' command for the MVBLUE. Andre, do you mind if the 'interrupts' command is not available the MVBLUE?
Thanks, Peter
Peter,
On second thought, this will disable both the 'interrupts' and 'irqinfo' command for the MVBLUE. Andre, do you mind if the 'interrupts' command is not available the MVBLUE?
please go ahead - no problem at all.
Regards, André
MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler Registergericht: Amtsgericht Stuttgart, HRB 271090 Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Hans-Joachim Reich
participants (3)
-
Andre Schwarz -
Peter Tyser -
Wolfgang Denk