[U-Boot-Users] Make ADS5121 out-of-tree compiling compatible
Wolfgang,
Please review the following patch which fixes the out-of-tree compiling.
Regards,
York
Signed-off-by: York Sun yorksun@freescale.com --- board/ads5121/Makefile | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile index 8ace8a1..9b675f7 100644 --- a/board/ads5121/Makefile +++ b/board/ads5121/Makefile @@ -23,9 +23,14 @@
include $(TOPDIR)/config.mk
+$(shell mkdir -p $(OBJTREE)/board/freescale/common) + LIB = $(obj)lib$(BOARD).a
-COBJS-y := $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o +COBJS-y := $(BOARD).o +COBJS-y += ads5121_diu.o +COBJS-y += ../freescale/common/fsl_diu_fb.o +COBJS-y += ../freescale/common/fsl_logo_bmp.o COBJS-$(CONFIG_PCI) += pci.o
COBJS := $(COBJS-y)
In message 12103667861729-git-send-email-yorksun@freescale.com you wrote:
Signed-off-by: York Sun yorksun@freescale.com
board/ads5121/Makefile | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile index 8ace8a1..9b675f7 100644 --- a/board/ads5121/Makefile +++ b/board/ads5121/Makefile @@ -23,9 +23,14 @@
include $(TOPDIR)/config.mk
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
LIB = $(obj)lib$(BOARD).a
I'm missing some rule to remove that directory for "make clean" or "make distclean" ?
Best regards,
Wolfgang Denk
On Sat, 2008-05-10 at 01:17 +0200, Wolfgang Denk wrote:
include $(TOPDIR)/config.mk
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
LIB = $(obj)lib$(BOARD).a
I'm missing some rule to remove that directory for "make clean" or "make distclean" ?
No, you are not. You have the following in Makefile
distclean: clobber unconfig rm -rf $(obj)* endif
All temporary folders are removed.
I just resent you the v2 patch.
York
On Fri, 9 May 2008, York Sun wrote:
Signed-off-by: York Sun yorksun@freescale.com
board/ads5121/Makefile | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/board/ads5121/Makefile b/board/ads5121/Makefile index 8ace8a1..9b675f7 100644 --- a/board/ads5121/Makefile +++ b/board/ads5121/Makefile @@ -23,9 +23,14 @@
include $(TOPDIR)/config.mk
+$(shell mkdir -p $(OBJTREE)/board/freescale/common)
LIB = $(obj)lib$(BOARD).a
-COBJS-y := $(BOARD).o ads5121_diu.o ../freescale/common/fsl_diu_fb.o ../freescale/common/fsl_logo_bmp.o +COBJS-y := $(BOARD).o +COBJS-y += ads5121_diu.o +COBJS-y += ../freescale/common/fsl_diu_fb.o +COBJS-y += ../freescale/common/fsl_logo_bmp.o COBJS-$(CONFIG_PCI) += pci.o
COBJS := $(COBJS-y)
Why don't you just define CONFIG_FSL_DIU_FB in the ads5121 config.h? Then you don't have to build the common objects in this Makefile as board/freescale/common/Makefile will handle them.
- k
participants (3)
-
Kumar Gala -
Wolfgang Denk -
York Sun