[U-Boot] [PATCH] efi_loader: Add debug output for efi_add_memory_map()
Tracing the arguments has been helpful for pinpointing overflows.
Cc: Alexander Graf agraf@suse.de Signed-off-by: Andreas Färber afaerber@suse.de --- lib/efi_loader/efi_memory.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index df99585..138736f 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -123,6 +123,11 @@ uint64_t efi_add_memory_map(uint64_t start, uint64_t pages, int memory_type, struct efi_mem_list *newlist; bool do_carving;
+#ifdef DEBUG_EFI + printf("%s: 0x%" PRIx64 " 0x%" PRIx64 " %d %s\n", __func__, + start, pages, memory_type, overlap_only_ram ? "yes" : "no"); +#endif + if (!pages) return start;
On 13.04.16 05:33, Andreas Färber wrote:
Tracing the arguments has been helpful for pinpointing overflows.
Cc: Alexander Graf agraf@suse.de Signed-off-by: Andreas Färber afaerber@suse.de
Reviewed-by: Alexander Graf agraf@suse.de
Alex
lib/efi_loader/efi_memory.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index df99585..138736f 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -123,6 +123,11 @@ uint64_t efi_add_memory_map(uint64_t start, uint64_t pages, int memory_type, struct efi_mem_list *newlist; bool do_carving;
+#ifdef DEBUG_EFI
- printf("%s: 0x%" PRIx64 " 0x%" PRIx64 " %d %s\n", __func__,
start, pages, memory_type, overlap_only_ram ? "yes" : "no");+#endif
- if (!pages) return start;
On Wed, Apr 13, 2016 at 05:33:50AM +0200, Andreas Färber wrote:
Tracing the arguments has been helpful for pinpointing overflows.
Cc: Alexander Graf agraf@suse.de Signed-off-by: Andreas Färber afaerber@suse.de
lib/efi_loader/efi_memory.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c index df99585..138736f 100644 --- a/lib/efi_loader/efi_memory.c +++ b/lib/efi_loader/efi_memory.c @@ -123,6 +123,11 @@ uint64_t efi_add_memory_map(uint64_t start, uint64_t pages, int memory_type, struct efi_mem_list *newlist; bool do_carving;
+#ifdef DEBUG_EFI
- printf("%s: 0x%" PRIx64 " 0x%" PRIx64 " %d %s\n", __func__,
start, pages, memory_type, overlap_only_ram ? "yes" : "no");+#endif
- if (!pages) return start;
This should be using debug() instead. And in fact can you please do a clean up series to make EFI use DEBUG (for toggling EFI_ENTRY extra debug stuff) and debug() instead of adding a new symbol? Thanks!
participants (3)
-
Alexander Graf -
Andreas Färber -
Tom Rini