[U-Boot] [PATCH 3/3] fsl_sata: Move the snoop bit to another place
For P1022 SATA host controller, the data snoop bit of DW3 in PRDT is moved to bit28.
Signed-off-by: Dave Liu daveliu@freescale.com --- drivers/block/fsl_sata.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/block/fsl_sata.h b/drivers/block/fsl_sata.h index 18e88fa..75165ab 100644 --- a/drivers/block/fsl_sata.h +++ b/drivers/block/fsl_sata.h @@ -244,7 +244,11 @@ typedef struct prd_entry { /* ext_c_ddc */ #define PRD_ENTRY_EXT 0x80000000 /* extension flag or called indirect descriptor flag */ +#ifdef CONFIG_P1022 +#define PRD_ENTRY_DATA_SNOOP 0x10000000 /* Snoop enable for all data associated with the PRD entry */ +#else #define PRD_ENTRY_DATA_SNOOP 0x00400000 /* Snoop enable for all data associated with the PRD entry */ +#endif #define PRD_ENTRY_LEN_MASK 0x003fffff /* Data word count */
#define PRD_ENTRY_MAX_XFER_SZ (PRD_ENTRY_LEN_MASK + 1)
On Apr 8, 2010, at 2:58 AM, Dave Liu wrote:
For P1022 SATA host controller, the data snoop bit of DW3 in PRDT is moved to bit28.
Signed-off-by: Dave Liu daveliu@freescale.com
drivers/block/fsl_sata.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/block/fsl_sata.h b/drivers/block/fsl_sata.h index 18e88fa..75165ab 100644 --- a/drivers/block/fsl_sata.h +++ b/drivers/block/fsl_sata.h @@ -244,7 +244,11 @@ typedef struct prd_entry { /* ext_c_ddc */ #define PRD_ENTRY_EXT 0x80000000 /* extension flag or called indirect descriptor flag */ +#ifdef CONFIG_P1022
This should be something like CONFIG_FSL_SATA_V2. While P1022 is the first others will need this change and its more specific the the 2nd generation of the SATA HW IP block.
My preference is to make it run time if we can determine the IP block version based on a register read.
+#define PRD_ENTRY_DATA_SNOOP 0x10000000 /* Snoop enable for all data associated with the PRD entry */ +#else #define PRD_ENTRY_DATA_SNOOP 0x00400000 /* Snoop enable for all data associated with the PRD entry */ +#endif #define PRD_ENTRY_LEN_MASK 0x003fffff /* Data word count */
#define PRD_ENTRY_MAX_XFER_SZ (PRD_ENTRY_LEN_MASK + 1)
1.6.4
u-boot-release mailing list u-boot-release@linux.freescale.net http://linux.freescale.net/mailman/listinfo/u-boot-release
+#ifdef CONFIG_P1022
This should be something like CONFIG_FSL_SATA_V2. While P1022 is the first others will need this change and its more specific the the 2nd generation of the SATA HW IP block.
Good idea, CONFIG_FSL_SATA_V2 is better.
participants (3)
-
Dave Liu -
Kumar Gala -
Liu Dave-R63238