Re: [U-Boot-Users] [PATCH] Add stricmp to lib_generic/string.c
From: Wolfgang Denk wd@denx.de Date: Wed, 03 May 2006 01:01:29 +0200
In message 5642B638DBEF6A4DBF9E9BC68144866D0276A64E@tamail1.timeamerica.com you
wrote:
Curiously enough I also ran a check to see where strnicmp is being
used
in all of U-Boot, since I was considering using it instead, and it doesn't seem to be used at all either even though its already in string.c. I will avoid using it as well since its an obvious
candidate
for elimination.
Thanks for pointing out. I have to admit that I was not aware that we even had this function. It's gone now :-)
Hold on a second. I've been using strnicmp (because stricmp wasn't there) to check environment variable values against strings. Why would I force my users to start being case-sensitive when setting up which lcd display to initialize?
What other standard library function allows case flexibility in comparing user input? (i.e. what would you suggest as an alternative to using strnicmp?)
If a particular board doesn't use it, the linker can strip it out.
Tim Braun, Sr. Des. Eng. LibreStream Technologies 200-55 Rothwell Rd. Winnipeg R3P 2M5
In message 8230E1CC35AF9F43839F3049E930169A2DCBE1@yang.LibreStream.local you wrote:
Thanks for pointing out. I have to admit that I was not aware that we even had this function. It's gone now :-)
Hold on a second. I've been using strnicmp (because stricmp wasn't there) to check environment
Have you? Sorry. None of this is visible in the public U-Boot tree. Sorry, strnicmp() is gone.
variable values against strings. Why would I force my users to start being case-sensitive when setting up which lcd display to initialize?
Why not?
If a particular board doesn't use it, the linker can strip it out.
I don't want code bloat. If none of the boards uses it (as is the case right now) we don't need it, so off it goes.
Best regards,
Wolfgang Denk
participants (2)
-
Tim Braun -
Wolfgang Denk