Hi Haijun,

On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote:

Erass sequence:

1. check if erase command is support by card. If not return.
2. Check the erase range to see if it was aligned. The min erase size

should be one erase group. SD card it was one block(512), mmc card it should be one erase group. 3. If not, aligned the erase rang according to the erase group size. 4. Send erase command to erase card once one erase group. 5. If it was SD card, erase with arg 0x00000000 should be send. else if support secure feature, erase with arg 0x80000000(Spec eMMC 4.41). else erase with arg 0x00000000.(Trim and discard is ingnored here) 6. Check card status after erase.

Can I get a few lines about what this patch implements before explaining the algorithm?

Something like

"This patch enhances the currently implemented erase procedure in u-boot, which has the following problems/missing features..."

Signed-off-by: Haijun Zhang haijun.zhang@freescale.com

drivers/mmc/mmc_write.c | 70 ++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 60 insertions(+), 10 deletions(-)

diff --git a/drivers/mmc/mmc_write.c b/drivers/mmc/mmc_write.c index aa2fdef..f2e9baf 100644 --- a/drivers/mmc/mmc_write.c +++ b/drivers/mmc/mmc_write.c @@ -17,6 +17,10 @@ static ulong mmc_erase_t(struct mmc *mmc, ulong start, lbaint_t blkcnt) struct mmc_cmd cmd; ulong end; int err, start_cmd, end_cmd;

• uint arg = 0;

• if (!(mmc->cmdclass & CCC_ERASE))

• return NOT_SUPPORT;
  
  

  if (mmc->high_capacity) { end = start + blkcnt - 1;

@@ -48,8 +52,17 @@ static ulong mmc_erase_t(struct mmc *mmc, ulong start, lbaint_t blkcnt) if (err) goto err_out;

• arg = MMC_ERASE_ARG;
• if (mmc->sec_feature_support & EXT_CSD_SEC_ER_EN)

• arg = MMC_SECURE_ERASE_ARG;
  

• /* SD card only support %MMC_ERASE_ARG */
• if (IS_SD(mmc))

• arg = MMC_ERASE_ARG;
  

Shouldn't that be:

/* SD card only support %MMC_ERASE_ARG */ if (!IS_SD(mmc) && (mmc->sec_feature_support & EXT_CSD_SEC_ER_EN)) arg = MMC_SECURE_ERASE_ARG; else arg = MMC_ERASE_ARG;

cmd.cmdidx = MMC_CMD_ERASE;

• cmd.cmdarg = SECURE_ERASE;

• cmd.cmdarg = arg; cmd.resp_type = MMC_RSP_R1b;

  err = mmc_send_cmd(mmc, &cmd, NULL);

@@ -69,24 +82,61 @@ unsigned long mmc_berase(int dev_num, lbaint_t start, lbaint_t blkcnt) struct mmc *mmc = find_mmc_device(dev_num); lbaint_t blk = 0, blk_r = 0; int timeout = 1000;

• int res;

• bool align = false;

  if (!mmc) return -1;

• if (!(mmc->cmdclass & CCC_ERASE)) {

• printf("\nErase operation is not support by card\n");
  

• return NOT_SUPPORT;
  

• }

• if ((start % mmc->erase_grp_size) || (blkcnt % mmc->erase_grp_size))

• align = true;
  

^ The use of align here is confusing.

AFAIKT the meaning is reversed.

align actually means not_aligned.

• res = start % mmc->erase_grp_size;
• if (res) {

• res = mmc->erase_grp_size - res;
  

• start += res;
  

• if (blkcnt > res)
  

• 	blkcnt -= res;
  

• else {
  

• 	printf("\nErase size smaller than Erase group "
  

• 		"size [0x%x] is not support by the device.\n",
  

• 		mmc->erase_grp_size);
  

• 	return NOT_SUPPORT;
  

• }
  

• }
• res = blkcnt % mmc->erase_grp_size;
• if (res)

• blkcnt -= res;
  

• if (!blkcnt) {

• printf("\nErase size smaller than Erase group size [0x%x] "
  

• 	"is not support by the device.\n",
  

• 	mmc->erase_grp_size);
  

• return NOT_SUPPORT;
  

• }
• if (align) printf("\n\nCaution! Your devices Erase group is 0x%x\n"

•        "The erase range would be change to "
  

•        "0x" LBAF "~0x" LBAF "\n\n",
  

•        mmc->erase_grp_size, start & ~(mmc->erase_grp_size - 1),
  

•        ((start + blkcnt + mmc->erase_grp_size)
  

•        & ~(mmc->erase_grp_size - 1)) - 1);
  

• 	"The erase range would be change to "
  

• 	"0x" LBAF "~0x" LBAF "\n\n",
  

• 	mmc->erase_grp_size, start, start + blkcnt);
  

• while (blk < blkcnt) {

• blk_r = ((blkcnt - blk) > mmc->erase_grp_size) ?
  

• 	mmc->erase_grp_size : (blkcnt - blk);
  

• if ((blkcnt - blk) >= mmc->erase_grp_size)
  

• 	blk_r = mmc->erase_grp_size;
  

  err = mmc_erase_t(mmc, start + blk, blk_r);

• if (err)
  

• 	break;
  

• if (err) {
  

• 	printf("\nErase range from 0x" LBAF "~0x" LBAF
  

• 		" Failed\n", start + blk, blkcnt);
  

• 	return COMM_ERR;
  

• }
  
  

  blk += blk_r;

-- 1.8.4

Regards

-- Pantelis

Dear Haijun,

Check the below message, plz.

cmd_mmc.c: In function ‘do_mmcops’: cmd_mmc.c:405:5: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses] cmd_mmc.c:406:5: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses] cmd_mmc.c:407:4: warning: comparisons like ‘X<=Y<=Z’ do not have their mathematical meaning [-Wparentheses]

Best Regards, Jaehoon Chung

On 11/05/2013 03:23 PM, Haijun Zhang wrote:

If the block rang was not algined, We tried to algined the range, then erase the block. So the block range erased should be less or equal to the block range send. If error occured during erase procedure part of them will be erased. And use should resend the block rang to continue erase the reset of them.

Error number and zero number mean erase operation was failed.

Signed-off-by: Haijun Zhang haijun.zhang@freescale.com

common/cmd_mmc.c | 7 +++++++ 1 file changed, 7 insertions(+)

diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index 67a94a7..15cecb7 100644 --- a/common/cmd_mmc.c +++ b/common/cmd_mmc.c @@ -397,6 +397,13 @@ static int do_mmcops(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) BUG(); }

• if (state == MMC_ERASE) {
  

• 	printf("%d blocks %s: %s\n",
  

• 		(cnt >= n > 0) ? n : 0, argv[1],
  

• 		(cnt >= n > 0) ? "OK" : "ERROR");
  

• 	return (cnt >= n > 0) ? 0 : 1;
  

• }
  

• printf("%d blocks %s: %s\n", n, argv[1], (n == cnt) ? "OK" : "ERROR"); return (n == cnt) ? 0 : 1;

Hi Haijun,

On Nov 5, 2013, at 8:23 AM, Haijun Zhang wrote:

The max timeout value esdhc host can accept was about 2.69 sec At 50 Mhz SD_CLK period, the max busy timeout value = 2^27 * SD_CLK period ~= 2.69 sec.

In case erase command CMD38 timeout is caculate by

^ calculated?

mult * 300ms * num(unit by erase group), so the time one erase group need should be more than 300ms, 500ms should be enough.

1. Add data reset for data error and command with busy error.
2. Add timeout value detecting during waiting transfer complete.
3. Ignore Command inhibit (DAT) state when excuting CMD12.
4. Add command CRC error detecting.
5. Enlarged the timeout value used for busy state release.
6. In case eSDHC host version 2.3, host will signal transfer complete

interrupt once busy state was release.

Signed-off-by: Haijun Zhang Haijun.Zhang@freescale.com

drivers/mmc/fsl_esdhc.c | 165 +++++++++++++++++++++++++++++++----------------- 1 file changed, 108 insertions(+), 57 deletions(-)

diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c index 9f4d3a2..a8503fb 100644 --- a/drivers/mmc/fsl_esdhc.c +++ b/drivers/mmc/fsl_esdhc.c @@ -266,26 +266,36 @@ static int esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data) { uint xfertyp;

• uint irqstat;

• uint irqstat, mask; struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv; volatile struct fsl_esdhc *regs = (struct fsl_esdhc *)cfg->esdhc_base;
• int ret = 0, timeout;
• esdhc_write32(&regs->irqstat, -1);

^ Please don't -1 for unsigned quantities. Use 0xffffffffU if need be.

I know it used to be -1, but since we're making the changes here, lets fix it in every case.

• sync();
• mask = PRSSTAT_CICHB | PRSSTAT_CIDHB;

#ifdef CONFIG_SYS_FSL_ERRATUM_ESDHC111 if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION) return 0; +#else

• if (cmd->cmdidx == MMC_CMD_STOP_TRANSMISSION)

• mask &= ~PRSSTAT_CIDHB;
  

#endif

• esdhc_write32(&regs->irqstat, -1);
• sync();
• /* Wait for the bus to be idle */
• while ((esdhc_read32(&regs->prsstat) & PRSSTAT_CICHB) ||

• 	(esdhc_read32(&regs->prsstat) & PRSSTAT_CIDHB))
  

• ;
  

• while (esdhc_read32(&regs->prsstat) & PRSSTAT_DLA)

• ;
  

• timeout = 1000;

• while (esdhc_read32(&regs->prsstat) & mask) {

• if (timeout == 0) {
  

• 	printf("\nController never released inhibit bit(s).\n");
  

• 	ret = COMM_ERR;
  

• 	goto reset;
  

• }
  

• timeout--;
  

• mdelay(1);
  

• }

  /* Wait at least 8 SD clock cycles before the next command */ /*

@@ -296,11 +306,9 @@ esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)

/* Set up for a data transfer if we have one */ if (data) {

• int err;
  

• err = esdhc_setup_data(mmc, data);
  

• if(err)
  

• 	return err;
  

• ret = esdhc_setup_data(mmc, data);
  

• if (ret)
  

• 	goto reset;
  

  }

  /* Figure out the transfer arguments */

@@ -325,43 +333,14 @@ esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data)

irqstat = esdhc_read32(&regs->irqstat);

• /* Reset CMD and DATA portions on error */
• if (irqstat & CMD_ERR) {

• esdhc_write32(&regs->sysctl, esdhc_read32(&regs->sysctl) |
  

• 	      SYSCTL_RSTC);
  

• while (esdhc_read32(&regs->sysctl) & SYSCTL_RSTC)
  

• 	;
  

• if (data) {
  

• 	esdhc_write32(&regs->sysctl,
  

• 		      esdhc_read32(&regs->sysctl) |
  

• 		      SYSCTL_RSTD);
  

• 	while ((esdhc_read32(&regs->sysctl) & SYSCTL_RSTD))
  

• 		;
  

• }
  

• if (irqstat & IRQSTAT_CTOE) {

• ret = TIMEOUT;
  

• goto reset;
  

  }

• if (irqstat & IRQSTAT_CTOE)

• return TIMEOUT;
  

• if (irqstat & CMD_ERR)

• return COMM_ERR;
  

• /* Workaround for ESDHC errata ENGcm03648 */
• if (!data && (cmd->resp_type & MMC_RSP_BUSY)) {

• int timeout = 2500;
  

• /* Poll on DATA0 line for cmd with busy signal for 250 ms */
  

• while (timeout > 0 && !(esdhc_read32(&regs->prsstat) &
  

• 			PRSSTAT_DAT0)) {
  

• 	udelay(100);
  

• 	timeout--;
  

• }
  

• if (timeout <= 0) {
  

• 	printf("Timeout waiting for DAT0 to go high!\n");
  

• 	return TIMEOUT;
  

• }
  

• if (irqstat & CMD_ERR) {

• ret = COMM_ERR;
  

• goto reset;
  

  }

  /* Copy the response to the response buffer */

@@ -379,28 +358,100 @@ esdhc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd, struct mmc_data *data) } else cmd->response[0] = esdhc_read32(&regs->cmdrsp0);

• /* Wait until all of the blocks are transferred */

• /*

• * At 50 Mhz SD_CLK period, the max busy timeout
  

• * value or data transfer time need was about
  

• * = 2^27 * SD_CLK period ~= 2.69 sec.
  

• * So wait max 10 sec for data transfer complete or busy
  

• * state release.
  

• */
  

• timeout = 10000;
• /*

• * eSDHC host V2.3 has response busy interrupt, so
  

• * we should wait for busy state to be released and data
  

• * was out of programing state before next command send.
  

• */
  

+#ifdef CONFIG_FSL_SDHC_V2_3

• if (data || (cmd->resp_type & MMC_RSP_BUSY)) {

+#else if (data) { +#endif #ifdef CONFIG_SYS_FSL_ESDHC_USE_PIO esdhc_pio_read_write(mmc, data); #else do { irqstat = esdhc_read32(&regs->irqstat);

• 	if (irqstat & IRQSTAT_DTOE)
  

• 		return TIMEOUT;
  

• 	if (irqstat & IRQSTAT_DTOE) {
  

• 		ret = TIMEOUT;
  

• 		break;
  

• 	}
  
  

• 	if (irqstat & DATA_ERR)
  

• 		return COMM_ERR;
  

• } while ((irqstat & DATA_COMPLETE) != DATA_COMPLETE);
  

• 	if (irqstat & DATA_ERR) {
  

• 		ret = COMM_ERR;
  

• 		break;
  

• 	}
  

• 	if (timeout <= 0) {
  

• 		ret = TIMEOUT;
  

• 		break;
  

• 	}
  

• 	mdelay(1);
  

• 	timeout--;
  

• } while (((irqstat & DATA_COMPLETE) != DATA_COMPLETE) &&
  

• 		(esdhc_read32(&regs->prsstat) & PRSSTAT_DLA));
  

#endif if (data->flags & MMC_DATA_READ) check_and_invalidate_dcache_range(cmd, data); }

• /* Workaround for ESDHC errata ENGcm03648 */
  

• if (!data && (cmd->resp_type & MMC_RSP_BUSY)) {

• int timeout = 5000;
  

• /* Poll on DATA0 line for cmd with busy signal for 500 ms */
  

• while (timeout > 0 && !(esdhc_read32(&regs->prsstat) &
  

• 			PRSSTAT_DAT0)) {
  

• 	udelay(100);
  

• 	timeout--;
  

• }
  

• if (timeout <= 0) {
  

• 	printf("\nTimeout waiting for DAT0 to go high!\n");
  

• 	ret = TIMEOUT;
  

• 	goto reset;
  

• }
  

• }

• if (ret)

• goto reset;
  

• esdhc_write32(&regs->irqstat, -1);

  return 0;

+reset:

• /* Reset CMD and DATA portions on error */
• if (irqstat & (CMD_ERR | DATA_ERR)) {

• esdhc_write32(&regs->sysctl, esdhc_read32(&regs->sysctl) |
  

• 		SYSCTL_RSTC);
  

• while (esdhc_read32(&regs->sysctl) & SYSCTL_RSTC)
  

• 	;
  

• if (data || (cmd->resp_type & MMC_RSP_BUSY)) {
  

• 	esdhc_write32(&regs->sysctl,
  

• 			esdhc_read32(&regs->sysctl) |
  

• 			SYSCTL_RSTA);
  

• 	while ((esdhc_read32(&regs->sysctl) & SYSCTL_RSTA))
  

• 		;
  

• }
  

In general I do not like loops without a timeout terminating condition. I'll let it pass for now, but please follow up with a patch for the whole driver turning those into timeout condition terminated loops.

• }
• esdhc_write32(&regs->irqstat, -1);
• return ret;

}

static void set_sysctl(struct mmc *mmc, uint clock)

1.8.4

Regards

-- Pantelis

Hi, Jaehoon

? 2013/11/8 9:15, Jaehoon Chung ??:

Dear Haijun,

On 11/05/2013 03:23 PM, Haijun Zhang wrote:

...

Add command class define. Add mmc erase and secure erase define. Add secure erase and trim support bit define.

Signed-off-by: Haijun Zhang haijun.zhang@freescale.com

include/mmc.h | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+)

diff --git a/include/mmc.h b/include/mmc.h index cb558da..26fab07 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -53,6 +53,7 @@ #define COMM_ERR -18 /* Communications Error */ #define TIMEOUT -19 #define IN_PROGRESS -20 /* operation is in progress */ +#define NOT_SUPPORT -21 /* Operation is not support */

#define MMC_CMD_GO_IDLE_STATE 0 #define MMC_CMD_SEND_OP_COND 1 @@ -105,6 +106,39 @@ #define OCR_VOLTAGE_MASK 0x007FFF80 #define OCR_ACCESS_MODE 0x60000000

+/*

• • Card Command Classes (CCC)
• • (0) Basic protocol functions (CMD0,1,2,3,4,7,9,10,12,13,15)
• • (and for SPI, CMD58,59)
• • (1) Stream read commands (CMD11)
• • (2) Block read commands (CMD16,17,18)
• • (3) Stream write commands (CMD20)
• • (4) Block write commands (CMD16,24,25,26,27)
• • (5) Ability to erase blocks (CMD32,33,34,35,36,37,38,39)
• • (6) Able to write protect blocks (CMD28,29,30)
• • (7) Able to lock down card (CMD16,CMD42)
• • (8) Application specific (CMD55,56,57,ACMD*)
• • (9) I/O mode (CMD5,39,40,52,53)
• • (10) High speed switch (CMD6,34,35,36,37,50)
• */

+#define CCC_BASIC (1<<0) +#define CCC_STREAM_READ (1<<1) +#define CCC_BLOCK_READ (1<<2) +#define CCC_STREAM_WRITE (1<<3) +#define CCC_BLOCK_WRITE (1<<4) +#define CCC_ERASE (1<<5) +#define CCC_WRITE_PROT (1<<6) +#define CCC_LOCK_CARD (1<<7) +#define CCC_APP_SPEC (1<<8) +#define CCC_IO_MODE (1<<9) +#define CCC_SWITCH (1<<10)

+#define MMC_ERASE_ARG 0x00000000 +#define MMC_SECURE_ERASE_ARG 0x80000000 +#define MMC_TRIM_ARG 0x00000001 +#define MMC_DISCARD_ARG 0x00000003

• #define SECURE_ERASE 0x80000000

  #define MMC_STATUS_MASK (~0x0206BF7F)

@@ -160,8 +194,12 @@ #define EXT_CSD_CARD_TYPE 196 /* RO */ #define EXT_CSD_SEC_CNT 212 /* RO, 4 bytes */ #define EXT_CSD_HC_WP_GRP_SIZE 221 /* RO */ +#define EXT_CSD_REL_WR_SEC_C 222 /* RO */ +#define EXT_CSD_ERASE_TIMEOUT_MULT 223 /* RO */ #define EXT_CSD_HC_ERASE_GRP_SIZE 224 /* RO */ #define EXT_CSD_BOOT_MULT 226 /* RO */ +#define EXT_CSD_SEC_ERASE_MULT 230 /* RO */ +#define EXT_CSD_SEC_FEATURE_SUPPORT 231 /* RO */

/*

• EXT_CSD field definitions

@@ -178,6 +216,12 @@ #define EXT_CSD_BUS_WIDTH_4 1 /* Card is in 4 bit mode */ #define EXT_CSD_BUS_WIDTH_8 2 /* Card is in 8 bit mode */

+#define EXT_CSD_SEC_ER_EN (1<<0)

Where is this bit defined?

EXT_CSD[231] bit 0 (eMMC 4.41 and eMMC4.5 or later?)

...

+#define EXT_CSD_SEC_BD_BLK_EN (1<<2) +#define EXT_CSD_SEC_GB_CL_EN (1<<4) +#define EXT_CSD_SEC_SANITIZE (1<<6) /* v4.5 only */

Which version do you refer? SEC_SANITIZE is only supported v4.5? then v4.51 or v5.0? I think that Comment need to modify. /* Since v4.5 */

Thanks, I change it.

...

remove the empty line.

Thanks.

Best Regards, Jaehoon Chung

...

#define EXT_CSD_BOOT_ACK_ENABLE (1 << 6) #define EXT_CSD_BOOT_PARTITION_ENABLE (1 << 3) #define EXT_CSD_PARTITION_ACCESS_ENABLE (1 << 0) @@ -268,10 +312,15 @@ struct mmc { ushort rca; char part_config; char part_num;

• ushort cmdclass; uint tran_speed; uint read_bl_len; uint write_bl_len; uint erase_grp_size;
• uint erase_timeout_mult;
• char sec_feature_support;
• uint sec_erase_mult;
• uint sec_erase_timeout; u64 capacity; u64 capacity_user; u64 capacity_boot;