Re: [U-Boot] Signed-off-by for RPI U-Boot USB patches
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
The main thing preventing me from sending the driver for inclusion in mainline U-Boot is that none of the commits in that branch contain a Signed-off-by tag from you. Could you please reply here with your s-o-b line for all the commits listed below?
Thank you very much!
For details of what s-o-b means, please see https://www.kernel.org/doc/Documentation/SubmittingPatches section 12 "Sign your work". (There's also a standalone website containing that section now, but I can't for the life of me find it...)
b22090f Fix usb_lowlevel_init and usb_lowlevel_stop 8d5c624 Merge of doom: update to latest u-boot cd2dac2 Increase buffer for bulk transfers and make virtual hub highspeed fc4164b Enable USB mass storage support 9085155 Increase timeout for soft reset 4b3863c More sophysticated initialization code 8cb8ecc Rmeove hardcoded MAC address 6ab7258 Report error, do not hang 9e5763c Fix typo and whitespaces d141598 Fix memory layout for U-Boot 5d8b20f Cleanup and add function declarations eb2bb98 Add sanity check, just in case 8c85e48 Clean up mess with buffers d8fb4c3 Get rid of device-specific structures/registers ce7f827 Merge branch 'rpi' of github.com:gonzoua/u-boot-pi into rpi a78f29e Slap licenses on top of the newly created files d80dd6a Remove debug level cc7227e Minor cleanup 0d3c12f More stable CONTROL transfers, working BULK transfers 9da26b0 Remove debug output 70f4b54 Add support for USB ethernet and SMSC95XX ae9e5fc Add stripped-down version of Linux driver for DWC OTG a1bfc20 Skeleton DWC OTG driver implementation b47e41c Slap licenses on top of the newly created files ded1dc9 Remove debug level 602704e Minor cleanup ecc6e3d More stable CONTROL transfers, working BULK transfers d966ac2 Add support for USB ethernet and SMSC95XX 71633e5 Add stripped-down version of Linux driver for DWC OTG 182c5b0 Skeleton DWC OTG driver implementation
(yes, there are duplicate entries in that list, because there are in the git tree I took the code from)
linux-rpi-kernel mailing list linux-rpi-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
On Sat, Feb 01, 2014 at 11:17:03PM -0700, Stephen Warren wrote:
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
The main thing preventing me from sending the driver for inclusion in mainline U-Boot is that none of the commits in that branch contain a Signed-off-by tag from you. Could you please reply here with your s-o-b line for all the commits listed below?
Thank you very much!
For details of what s-o-b means, please see https://www.kernel.org/doc/Documentation/SubmittingPatches section 12 "Sign your work". (There's also a standalone website containing that section now, but I can't for the life of me find it...)
http://developercertificate.org/ is what you are looking for.
On 2014-02-01, at 10:17 PM, Stephen Warren swarren@wwwdotorg.org wrote:
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
Nice to know :) Thanks for bringing this stuff to upstream.
The main thing preventing me from sending the driver for inclusion in mainline U-Boot is that none of the commits in that branch contain a Signed-off-by tag from you. Could you please reply here with your s-o-b line for all the commits listed below?
I really should start using commit -s :)
Signed-off-by: Oleksandr Tymoshenko gonzo@bluezbox.com
Thank you very much!
For details of what s-o-b means, please see https://www.kernel.org/doc/Documentation/SubmittingPatches section 12 "Sign your work". (There's also a standalone website containing that section now, but I can't for the life of me find it...)
b22090f Fix usb_lowlevel_init and usb_lowlevel_stop 8d5c624 Merge of doom: update to latest u-boot cd2dac2 Increase buffer for bulk transfers and make virtual hub highspeed fc4164b Enable USB mass storage support 9085155 Increase timeout for soft reset 4b3863c More sophysticated initialization code 8cb8ecc Rmeove hardcoded MAC address 6ab7258 Report error, do not hang 9e5763c Fix typo and whitespaces d141598 Fix memory layout for U-Boot 5d8b20f Cleanup and add function declarations eb2bb98 Add sanity check, just in case 8c85e48 Clean up mess with buffers d8fb4c3 Get rid of device-specific structures/registers ce7f827 Merge branch 'rpi' of github.com:gonzoua/u-boot-pi into rpi a78f29e Slap licenses on top of the newly created files d80dd6a Remove debug level cc7227e Minor cleanup 0d3c12f More stable CONTROL transfers, working BULK transfers 9da26b0 Remove debug output 70f4b54 Add support for USB ethernet and SMSC95XX ae9e5fc Add stripped-down version of Linux driver for DWC OTG a1bfc20 Skeleton DWC OTG driver implementation b47e41c Slap licenses on top of the newly created files ded1dc9 Remove debug level 602704e Minor cleanup ecc6e3d More stable CONTROL transfers, working BULK transfers d966ac2 Add support for USB ethernet and SMSC95XX 71633e5 Add stripped-down version of Linux driver for DWC OTG 182c5b0 Skeleton DWC OTG driver implementation
(yes, there are duplicate entries in that list, because there are in the git tree I took the code from)
linux-rpi-kernel mailing list linux-rpi-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
Hi Stephen,
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
Could you be more specific about the exact DWC USB IP block, which you plan to port for PI?
Is this host or device controller?
The USB controller designed by DesignWare is very popular (at least the USB 2.0) in the industry.
For example in u-boot there already is s3c_udc_*.c implementation for device controller. Also you can look into the s3c_hsotg.c in the linux mainline kernel.
The main thing preventing me from sending the driver for inclusion in mainline U-Boot is that none of the commits in that branch contain a Signed-off-by tag from you. Could you please reply here with your s-o-b line for all the commits listed below?
Thank you very much!
For details of what s-o-b means, please see https://www.kernel.org/doc/Documentation/SubmittingPatches section 12 "Sign your work". (There's also a standalone website containing that section now, but I can't for the life of me find it...)
b22090f Fix usb_lowlevel_init and usb_lowlevel_stop 8d5c624 Merge of doom: update to latest u-boot cd2dac2 Increase buffer for bulk transfers and make virtual hub highspeed fc4164b Enable USB mass storage support 9085155 Increase timeout for soft reset 4b3863c More sophysticated initialization code 8cb8ecc Rmeove hardcoded MAC address 6ab7258 Report error, do not hang 9e5763c Fix typo and whitespaces d141598 Fix memory layout for U-Boot 5d8b20f Cleanup and add function declarations eb2bb98 Add sanity check, just in case 8c85e48 Clean up mess with buffers d8fb4c3 Get rid of device-specific structures/registers ce7f827 Merge branch 'rpi' of github.com:gonzoua/u-boot-pi into rpi a78f29e Slap licenses on top of the newly created files d80dd6a Remove debug level cc7227e Minor cleanup 0d3c12f More stable CONTROL transfers, working BULK transfers 9da26b0 Remove debug output 70f4b54 Add support for USB ethernet and SMSC95XX ae9e5fc Add stripped-down version of Linux driver for DWC OTG a1bfc20 Skeleton DWC OTG driver implementation b47e41c Slap licenses on top of the newly created files ded1dc9 Remove debug level 602704e Minor cleanup ecc6e3d More stable CONTROL transfers, working BULK transfers d966ac2 Add support for USB ethernet and SMSC95XX 71633e5 Add stripped-down version of Linux driver for DWC OTG 182c5b0 Skeleton DWC OTG driver implementation
(yes, there are duplicate entries in that list, because there are in the git tree I took the code from)
linux-rpi-kernel mailing list linux-rpi-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On 02/03/2014 01:23 AM, Lukasz Majewski wrote:
Hi Stephen,
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
Could you be more specific about the exact DWC USB IP block, which you plan to port for PI?
Is this host or device controller?
The USB controller designed by DesignWare is very popular (at least the USB 2.0) in the industry.
For example in u-boot there already is s3c_udc_*.c implementation for device controller. Also you can look into the s3c_hsotg.c in the linux mainline kernel.
It's a driver for the DWC2 IP block, acting as a host controller (I don't know if this one can act as a device or not).
(part of my upstreaming process will likely require s/dwc/dwc2/ everywhere, since I know there's at least a DWC3 in the kernel, and I would assume that means there could be a DWC1 somewhere too).
Hi Stephen,
On 02/03/2014 01:23 AM, Lukasz Majewski wrote:
Hi Stephen,
(Sorry for the spam; resending with the correct U-Boot mailing list in CC)
On 02/01/2014 11:14 PM, Stephen Warren wrote:
Oleksandr, I'm starting to look at getting USB support enabled for the Raspberry Pi in mainline U-Boot. To that end, I looked at:
git://github.com/gonzoua/u-boot-pi.git rpi
I took the DWC driver from there and applied it to a very recent mainline U-Boot. It works very well:-)
Could you be more specific about the exact DWC USB IP block, which you plan to port for PI?
Is this host or device controller?
The USB controller designed by DesignWare is very popular (at least the USB 2.0) in the industry.
For example in u-boot there already is s3c_udc_*.c implementation for device controller. Also you can look into the s3c_hsotg.c in the linux mainline kernel.
It's a driver for the DWC2 IP block, acting as a host controller (I don't know if this one can act as a device or not).
As fair as I remember the mainline dwc2 is only for host. The one about which I've mentioned is a USB device driver (for the same IP block), so probably there is a little chance to reuse the existing code.
(part of my upstreaming process will likely require s/dwc/dwc2/ everywhere, since I know there's at least a DWC3 in the kernel, and I would assume that means there could be a DWC1 somewhere too).
I doubt that there is a DWC1 driver. DWC2 indicates (probably) that the IP block works with devices up to USB 2.0. In the same manner DWC3 indicates Super Speed (3.0).
The goal of my question was to reuse/improve existing code for the same IP block.
participants (4)
-
Greg KH -
Lukasz Majewski -
Oleksandr Tymoshenko -
Stephen Warren