[U-Boot] [PATCH] lib_ppc: Move trap_init to occur earlier
Doing trap_init immediately once we're running from RAM means we're no longer dependent on the physical location of the flash on non-BookE platforms. Before trap_init, those platforms switch to real mode and go to 0xfff00100 on exception. After the switch, they go to 0x00000100 This makes it easier to move the flash location.
Signed-off-by: Becky Bruce becky.bruce@freescale.com --- lib_ppc/board.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib_ppc/board.c b/lib_ppc/board.c index ce07c4e..289a32a 100644 --- a/lib_ppc/board.c +++ b/lib_ppc/board.c @@ -689,6 +689,11 @@ void board_init_r (gd_t *id, ulong dest_addr)
WATCHDOG_RESET ();
+ /* + * Setup trap handlers + */ + trap_init (dest_addr); + #if defined(CONFIG_BOARD_EARLY_INIT_R) board_early_init_r (); #endif @@ -765,11 +770,6 @@ void board_init_r (gd_t *id, ulong dest_addr)
asm ("sync ; isync");
- /* - * Setup trap handlers - */ - trap_init (dest_addr); - #if !defined(CONFIG_SYS_NO_FLASH) puts ("FLASH: ");
On Fri, 2008-10-31 at 17:14 -0500, Becky Bruce wrote:
Doing trap_init immediately once we're running from RAM means we're no longer dependent on the physical location of the flash on non-BookE platforms. Before trap_init, those platforms switch to real mode and go to 0xfff00100 on exception. After the switch, they go to 0x00000100 This makes it easier to move the flash location.
Signed-off-by: Becky Bruce becky.bruce@freescale.com
lib_ppc/board.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
Wolfgang,
Will you pick this one up? Or would you like me to run it through u-boot-mpc86xx with the others?
Thanks, jdl
On Mon, 2008-11-03 at 10:18 -0600, Jon Loeliger wrote:
On Fri, 2008-10-31 at 17:14 -0500, Becky Bruce wrote:
Doing trap_init immediately once we're running from RAM means we're no longer dependent on the physical location of the flash on non-BookE platforms. Before trap_init, those platforms switch to real mode and go to 0xfff00100 on exception. After the switch, they go to 0x00000100 This makes it easier to move the flash location.
Signed-off-by: Becky Bruce becky.bruce@freescale.com
lib_ppc/board.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-)
Wolfgang,
Will you pick this one up? Or would you like me to run it through u-boot-mpc86xx with the others?
Thanks, jdl
Wolfgang,
I spoke to Becky about this patch and she says it is required for the rest of her 86xx patches to work. So I will pick this one up and run it through the u-boot-mpc86xx git tree.
Thanks, jdl
Dear Jon,
In message 1226332549.6112.3.camel@ld0161-tx32 you wrote:
I spoke to Becky about this patch and she says it is required for the rest of her 86xx patches to work. So I will pick this one up and run it through the u-boot-mpc86xx git tree.
OK - and sorry for being unresponsive so long.
Best regards,
Wolfgang Denk
Dear Jon,
In message 1225729137.17577.17.camel@ld0161-tx32 you wrote:
Will you pick this one up? Or would you like me to run it through u-boot-mpc86xx with the others?
Thanks for running it through the 86xx repo for me.
Best regards,
Wolfgang Denk
participants (3)
-
Becky Bruce -
Jon Loeliger -
Wolfgang Denk