[U-Boot] [PATCH v2 5/9] sandbox: sort header files in os.c
Tidy this up as the list is long and likely to get longer.
Signed-off-by: Simon Glass sjg@chromium.org --- Changes in v2: - Sort correctly: include/, sys/, linux/, asm/
arch/sandbox/cpu/os.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c index 6d55b5c..52062ef 100644 --- a/arch/sandbox/cpu/os.c +++ b/arch/sandbox/cpu/os.c @@ -19,19 +19,18 @@ * MA 02111-1307 USA */
+#include <errno.h> #include <fcntl.h> +#include <os.h> #include <stdlib.h> #include <termios.h> -#include <unistd.h> #include <time.h> -#include <errno.h> -#include <sys/types.h> -#include <sys/stat.h> +#include <unistd.h> #include <sys/mman.h> +#include <sys/stat.h> +#include <sys/types.h> #include <linux/types.h>
-#include <os.h> - /* Operating System Interface */
ssize_t os_read(int fd, void *buf, size_t count)
We should include sys/time.h header to avoid warnings.
Signed-off-by: Simon Glass sjg@chromium.org --- Changes in v2: - Rebase after changes to sandbox header sort patch
arch/sandbox/cpu/os.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c index 52062ef..1efb0cd 100644 --- a/arch/sandbox/cpu/os.c +++ b/arch/sandbox/cpu/os.c @@ -28,6 +28,7 @@ #include <unistd.h> #include <sys/mman.h> #include <sys/stat.h> +#include <sys/time.h> #include <sys/types.h> #include <linux/types.h>
On Monday 09 January 2012 17:25:15 Simon Glass wrote:
--- a/arch/sandbox/cpu/os.c +++ b/arch/sandbox/cpu/os.c
+#include <errno.h> #include <fcntl.h> +#include <os.h> #include <stdlib.h> #include <termios.h> -#include <unistd.h> #include <time.h> -#include <errno.h> -#include <sys/types.h> -#include <sys/stat.h> +#include <unistd.h> #include <sys/mman.h> +#include <sys/stat.h> +#include <sys/types.h> #include <linux/types.h>
-#include <os.h>
this is a u-boot header, so it should be last :)
the rest look good now -mike
Hi Mike,
On Tue, Jan 10, 2012 at 10:07 AM, Mike Frysinger vapier@gentoo.org wrote:
On Monday 09 January 2012 17:25:15 Simon Glass wrote:
--- a/arch/sandbox/cpu/os.c +++ b/arch/sandbox/cpu/os.c
+#include <errno.h> #include <fcntl.h> +#include <os.h> #include <stdlib.h> #include <termios.h> -#include <unistd.h> #include <time.h> -#include <errno.h> -#include <sys/types.h> -#include <sys/stat.h> +#include <unistd.h> #include <sys/mman.h> +#include <sys/stat.h> +#include <sys/types.h> #include <linux/types.h>
-#include <os.h>
this is a u-boot header, so it should be last :)
Oh dear, I thought they were all U-Boot headers, but I think I see what you mean.
v3 coming...
Regards, Simon
the rest look good now -mike
participants (2)
-
Mike Frysinger -
Simon Glass