[PATCH v1 1/2] x86: edison: Enable command line editing

From: Marek Vasut marex@denx.de
Enable command line editing, because it is extremely convenient.
Signed-off-by: Marek Vasut marex@denx.de Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- configs/edison_defconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/configs/edison_defconfig b/configs/edison_defconfig index 14b2eec3ba..124f0f628f 100644 --- a/configs/edison_defconfig +++ b/configs/edison_defconfig @@ -9,7 +9,6 @@ CONFIG_SMP=y CONFIG_BOARD_EARLY_INIT_R=y CONFIG_LAST_STAGE_INIT=y CONFIG_HUSH_PARSER=y -# CONFIG_CMDLINE_EDITING is not set CONFIG_CMD_CPU=y CONFIG_CMD_ASKENV=y CONFIG_CMD_GREPENV=y

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- configs/edison_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/edison_defconfig b/configs/edison_defconfig index 124f0f628f..58707d619a 100644 --- a/configs/edison_defconfig +++ b/configs/edison_defconfig @@ -6,6 +6,7 @@ CONFIG_NR_DRAM_BANKS=3 CONFIG_VENDOR_INTEL=y CONFIG_TARGET_EDISON=y CONFIG_SMP=y +CONFIG_GENERATE_ACPI_TABLE=y CONFIG_BOARD_EARLY_INIT_R=y CONFIG_LAST_STAGE_INIT=y CONFIG_HUSH_PARSER=y

On Thu, Jan 09, 2020 at 11:12:35PM +0200, Andy Shevchenko wrote:
SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Bin, Simon, can we get these into 2020.04?
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/configs/edison_defconfig b/configs/edison_defconfig index 124f0f628f..58707d619a 100644 --- a/configs/edison_defconfig +++ b/configs/edison_defconfig @@ -6,6 +6,7 @@ CONFIG_NR_DRAM_BANKS=3 CONFIG_VENDOR_INTEL=y CONFIG_TARGET_EDISON=y CONFIG_SMP=y +CONFIG_GENERATE_ACPI_TABLE=y CONFIG_BOARD_EARLY_INIT_R=y CONFIG_LAST_STAGE_INIT=y CONFIG_HUSH_PARSER=y -- 2.24.1

On Wed, 29 Jan 2020 at 09:16, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Thu, Jan 09, 2020 at 11:12:35PM +0200, Andy Shevchenko wrote:
SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Bin, Simon, can we get these into 2020.04?
+Tom Rini FYI
Reviewed-by: Simon Glass sjg@chromium.org
I hope so. There's a small mountain of pending x86 patches. I think Bin is probably away until next week?
- Simon

On Thu, Jan 30, 2020 at 10:17 AM Simon Glass sjg@chromium.org wrote:
On Wed, 29 Jan 2020 at 09:16, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
On Thu, Jan 09, 2020 at 11:12:35PM +0200, Andy Shevchenko wrote:
SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Bin, Simon, can we get these into 2020.04?
+Tom Rini FYI
Reviewed-by: Simon Glass sjg@chromium.org
I hope so. There's a small mountain of pending x86 patches. I think Bin is probably away until next week?
I was off for the Chinese new year holiday vacation, and there was the 2019-nCov epidemic situation going on that further delayed things :(
I will pick up patches that make sense for v2020.04 release.
Regards, Bin

On Mon, Feb 3, 2020 at 7:01 AM Bin Meng bmeng.cn@gmail.com wrote:
On Thu, Jan 30, 2020 at 10:17 AM Simon Glass sjg@chromium.org wrote:
...
and there was the 2019-nCov epidemic situation going on that further delayed things :(
Oh, hope you are doing well!
I will pick up patches that make sense for v2020.04 release.
Thanks!

On Fri, Jan 10, 2020 at 5:12 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com

On Mon, Feb 3, 2020 at 12:59 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Jan 10, 2020 at 5:12 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.
Enable a necessary minimum to use ACPI on Intel Edison.
Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.
Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!

On Thu, 9 Jan 2020 at 14:12, Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
From: Marek Vasut marex@denx.de
Enable command line editing, because it is extremely convenient.
Signed-off-by: Marek Vasut marex@denx.de Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Simon Glass sjg@chromium.org

On Fri, Jan 10, 2020 at 5:12 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
From: Marek Vasut marex@denx.de
Enable command line editing, because it is extremely convenient.
Signed-off-by: Marek Vasut marex@denx.de Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com

On Mon, Feb 3, 2020 at 12:57 PM Bin Meng bmeng.cn@gmail.com wrote:
On Fri, Jan 10, 2020 at 5:12 AM Andy Shevchenko andriy.shevchenko@linux.intel.com wrote:
From: Marek Vasut marex@denx.de
Enable command line editing, because it is extremely convenient.
Signed-off-by: Marek Vasut marex@denx.de Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
configs/edison_defconfig | 1 - 1 file changed, 1 deletion(-)
Reviewed-by: Bin Meng bmeng.cn@gmail.com
applied to u-boot-x86, thanks!
participants (4)
-
Andy Shevchenko
-
Andy Shevchenko
-
Bin Meng
-
Simon Glass