[U-Boot] [PATCH 1/1] musb: properly detect failed initialization of controller

We want to check the result of musb_init_controller and not the address were the result is stored.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- drivers/usb/musb-new/musb_uboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c index ea71f75947..8662c0ff70 100644 --- a/drivers/usb/musb-new/musb_uboot.c +++ b/drivers/usb/musb-new/musb_uboot.c @@ -446,7 +446,7 @@ int musb_register(struct musb_hdrc_platform_data *plat, void *bdata, }
*musbp = musb_init_controller(plat, (struct device *)bdata, ctl_regs); - if (!musbp) { + if (!*musbp) { printf("Failed to init the controller\n"); return -EIO; }

On 04/15/2017 01:46 PM, Heinrich Schuchardt wrote:
We want to check the result of musb_init_controller and not the address were the result is stored.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied, thanks!
drivers/usb/musb-new/musb_uboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb-new/musb_uboot.c b/drivers/usb/musb-new/musb_uboot.c index ea71f75947..8662c0ff70 100644 --- a/drivers/usb/musb-new/musb_uboot.c +++ b/drivers/usb/musb-new/musb_uboot.c @@ -446,7 +446,7 @@ int musb_register(struct musb_hdrc_platform_data *plat, void *bdata, }
*musbp = musb_init_controller(plat, (struct device *)bdata, ctl_regs);
- if (!musbp) {
- if (!*musbp) { printf("Failed to init the controller\n"); return -EIO; }
participants (2)
-
Heinrich Schuchardt
-
Marek Vasut