[PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Heiko Schocher hs@denx.de Cc: Michal Simek michal.simek@xilinx.com --- drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c index 5926c91a2e..99eff8442a 100644 --- a/drivers/misc/i2c_eeprom.c +++ b/drivers/misc/i2c_eeprom.c @@ -262,6 +262,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = { static const struct udevice_id i2c_eeprom_std_ids[] = { { .compatible = "i2c-eeprom", (ulong)&eeprom_data }, { .compatible = "microchip,24aa02e48", (ulong)&mc24aa02e48_data }, + { .compatible = "atmel,24c01", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c01a", (ulong)&atmel24c01a_data }, { .compatible = "atmel,24c02", (ulong)&atmel24c02_data }, { .compatible = "atmel,24c04", (ulong)&atmel24c04_data },
Hello Marek,
On 04.07.21 21:31, Marek Vasut wrote:
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Heiko Schocher hs@denx.de Cc: Michal Simek michal.simek@xilinx.com
drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Heiko Schocher hs@denx.de
Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel, may we should remove it in U-Boot completly?
bye, Heiko
On 7/5/21 6:17 AM, Heiko Schocher wrote:
Hello Marek,
On 04.07.21 21:31, Marek Vasut wrote:
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Heiko Schocher hs@denx.de Cc: Michal Simek michal.simek@xilinx.com
drivers/misc/i2c_eeprom.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Heiko Schocher hs@denx.de
Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel, may we should remove it in U-Boot completly?
Sadly they are both used by the DTs, so we cannot. That's why we also have 24c08 and 24c08a in the compatibles, it's exactly the same change.
On Sun, Jul 04, 2021 at 09:31:18PM +0200, Marek Vasut wrote:
Linux kernel binding is using atmel,24c01 compatible string. On the other hand there is atmel,24c01a which is not listed in the kernel. Add compatible string without "a" suffix to be compatible with Linux kernel binding.
Signed-off-by: Marek Vasut marek.vasut+renesas@gmail.com Cc: Heiko Schocher hs@denx.de Cc: Michal Simek michal.simek@xilinx.com Reviewed-by: Heiko Schocher hs@denx.de
Applied to u-boot/master, thanks!
participants (4)
-
Heiko Schocher -
Marek Vasut -
Marek Vasut -
Tom Rini