[U-Boot-Users] at45.c repeated / ditto with flash.c (arm920t board)
Hi,
I'm new to the list. Is it OK to send patches here? I hope to receive your advise on how to send patches to U-boot.
I'm creating a patch against git/HEAD and I noticed that after the patch we get a file (at45.c) 3 times.
* Is it ok I send a patch to factor it?
* What example (a file that has been factored before) should I follow?
There is one difference between cmc_pu2/at91rm9200dk with a cast that seems to be there just to avoid a warning
$ find . -name at45.c ./board/cmc_pu2/at45.c ./board/at91rm9200dk/at45.c ./board/ecb_at91/at45.c
The patch also duplicates the file
board/at91rm9200dk/flash.c
Can it be factored? How should it be done?
Regards, Nelson.-
In message 2accc2ff0706040222g47a35bbdxe6151530114d1dd6@mail.gmail.com you wrote:
I'm new to the list. Is it OK to send patches here?
Yes, it is.
I hope to receive your advise on how to send patches to U-boot.
Please see http://www.denx.de/wiki/UBoot/Patches
I'm creating a patch against git/HEAD and I noticed that after the patch we get a file (at45.c) 3 times.
Please make sure to use the current code base, in this case the u-boot-arm custodian repository; see http://www.denx.de/wiki/UBoot/Custodians
- Is it ok I send a patch to factor it?
If it makes sense, of course.
The patch also duplicates the file
board/at91rm9200dk/flash.c
Can it be factored? How should it be done?
Umm... cannot you use the CFI driver instead?
Best regards,
Wolfgang Denk
On Mon, Jun 04, 2007 at 01:04:15PM +0200, Wolfgang Denk wrote:
In message 2accc2ff0706040222g47a35bbdxe6151530114d1dd6@mail.gmail.com you wrote:
I'm creating a patch against git/HEAD and I noticed that after the patch we get a file (at45.c) 3 times.
Please make sure to use the current code base, in this case the u-boot-arm custodian repository; see http://www.denx.de/wiki/UBoot/Custodians
This repository will not help him. It doesn't contain anything usefull from at91rm9200 perspective. But once I'm writing... Could anyone responsible tell me what should I do get at least *some* response to patches sent to mailing list? (except being patient, which I'm really good at ;-))
- Is it ok I send a patch to factor it?
If it makes sense, of course.
I'll send that patch for second time, splited to two smaller chunks for easier review.
The patch also duplicates the file
board/at91rm9200dk/flash.c
Can it be factored? How should it be done?
Umm... cannot you use the CFI driver instead?
Umm... cannot you use some less obsolete and broken by design chip? ;-)
Gmane search doesn't work for me, so you can try later yourself: From: Ladislav Michl ladis@linux-mips.org Subject: Re: [U-Boot-Users] [GIT PULL] AVR32 relocation Date: Fri, 2 Mar 2007 15:37:31 +0100 There is a patch and question. Again, could anyone (Tolunay) respond to question?
Best regards, ladis
participants (3)
-
Ladislav Michl -
Nelson Castillo -
Wolfgang Denk