[U-Boot-Users] [PATCH 6/6 ] Unified variable names and consolidated macro for TQM834x

Subject: [PATCH] Unified variable names and consolidated macro for TQM834x
---
board/tqm834x/pci.c | 12 ++++++------ include/configs/TQM834x.h | 12 ++++++++++++ 2 files changed, 18 insertions(+), 6 deletions(-)
205d48a033f0f2118845d26119416888f7e7c2f8 diff --git a/board/tqm834x/pci.c b/board/tqm834x/pci.c index 5a23e6c..d01277f 100644 --- a/board/tqm834x/pci.c +++ b/board/tqm834x/pci.c @@ -69,17 +69,17 @@ void pci_init_board(void) { volatile immap_t * immr; - volatile clk8349_t * clk; - volatile law8349_t * pci_law; - volatile pot8349_t * pci_pot; - volatile pcictrl8349_t * pci_ctrl; - volatile pciconf8349_t * pci_conf; + volatile clk83xx_t * clk; + volatile law83xx_t * pci_law; + volatile pot83xx_t * pci_pot; + volatile pcictrl83xx_t * pci_ctrl; + volatile pciconf83xx_t * pci_conf; u16 reg16; u32 reg32; struct pci_controller * hose;
immr = (immap_t *)CFG_IMMRBAR; - clk = (clk8349_t *)&immr->clk; + clk = (clk83xx_t *)&immr->clk; pci_law = immr->sysconf.pcilaw; pci_pot = immr->ios.pot; pci_ctrl = immr->pci_ctrl; diff --git a/include/configs/TQM834x.h b/include/configs/TQM834x.h index cec7e3e..5c469bf 100644 --- a/include/configs/TQM834x.h +++ b/include/configs/TQM834x.h @@ -36,6 +36,7 @@ #undef DEBUG */ #define CONFIG_E300 1 /* E300 Family */ #define CONFIG_MPC83XX 1 /* MPC83XX family */ +#define CONFIG_MPC8349 1 /* MPC8349 specific */ #define CONFIG_MPC834X 1 /* MPC834X specific */ #define CONFIG_TQM834X 1 /* TQM834X board specific */
@@ -56,6 +57,17 @@ #define CONFIG_83XX_CLKIN 66666000 /* 66 */ #define CFG_LCRR (LCRR_DBYP | LCRR_CLKDIV_8)
+#define CFG_SCCR_INIT (SCCR_DEFAULT & (~SCCR_CLK_MASK)) +#define CFG_SCCR_TSEC1CM SCCR_TSEC1CM_1 /* TSEC1 clock setting */ +#define CFG_SCCR_TSEC2CM SCCR_TSEC2CM_1 /* TSEC2 clock setting */ +#define CFG_SCCR_ENCCM SCCR_ENCCM_3 /* ENC clock setting */ +#define CFG_SCCR_USBCM SCCR_USBCM_3 /* USB clock setting */ +#define CFG_SCCR_VAL ( CFG_SCCR_INIT \ + | CFG_SCCR_TSEC1CM \ + | CFG_SCCR_TSEC2CM \ + | CFG_SCCR_ENCCM \ + | CFG_SCCR_USBCM ) + /* board pre init: do not call, nothing to do */ #undef CONFIG_BOARD_EARLY_INIT_F

In message 5B3767CDCE2C2B46B2BCB72C4833E888209658@zch01exm24.fsl.freescale.net you wrote:
Subject: [PATCH] Unified variable names and consolidated macro for TQM834x
Just one more question: Have you actually tested your changes on a TQM843x board? Or at least discussed these with the board maintainer?
I saw that you added a "#define CONFIG_MPC8349" to the board config file - what about board versions that use a different processor?
[I think this also needs better preparation before resubmitting.]
Best regards,
Wolfgang Denk
participants (2)
-
Jiang Bo-r61859
-
Wolfgang Denk