[U-Boot] [PATCH] TQM5200 HIGHBOOT Makefile patch
Hi, I don't know the normal procedure, if I should send the patch to Wolfgang or someone else, but I found a problem with Makefile and TQM5200 HIGHBOOT config in Makefile. I think this problem is also in previous versions since tqm boards where moved under tqc folder.
The patch is:
--- a/Makefile 2008-09-04 14:55:05.000000000 +0200 +++ b/Makefile 2008-09-04 14:56:14.000000000 +0200 @@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \ - { echo "TEXT_BASE = 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \ + { echo "TEXT_BASE = 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \ } @$(MKCONFIG) -n $@ -a TQM5200 ppc mpc5xxx tqm5200 tqc
Regards,
Pedro. _________________________________________________________________ Prueba los prototipos de los últimos en MSN Motor http://motor.es.msn.com/
Hi Pedro,
Hi, I don't know the normal procedure, if I should send the patch to Wolfgang or someone else, but I found a problem with Makefile and TQM5200 HIGHBOOT config in Makefile. I think this problem is also in previous versions since tqm boards where moved under tqc folder.
The normal procedure is to prepare a patch with git (use git-format-patch) against top of tree version so that it can be applied without any hassle (use git-send-email if you want to save a few iterations). Search the archives on more details on how to do this and be sure not to forget your Signed-off-by line.
Apart from that, the patch looks good.
Cheers Detlev
Dear "Pedro Luis D. L.",
In message BLU106-W37C60B6B3CB93D98D2C418CA590@phx.gbl you wrote:
I don't know the normal procedure, if I should send the patch to Wolfgang o= r someone else, but I found a problem with Makefile and TQM5200 HIGHBOOT co= nfig in Makefile. I think this problem is also in previous versions since t= qm boards where moved under tqc folder.
Please use a line length not longer than some 70+ characters.
The patch is:
--- a/Makefile 2008-09-04 14:55:05.000000000 +0200 +++ b/Makefile 2008-09-04 14:56:14.000000000 +0200 @@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \
{ echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \
{ echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \
Please re-submit after adding your Signed-off-by: line (and please follow the other instructions Detlev sent you).
Best regards,
Wolfgang Denk
On Sun, 7 Sep 2008 01:10:15 +0200 Wolfgang wrote:
Dear "Pedro Luis D. L.",
In message BLU106-W37C60B6B3CB93D98D2C418CA590@phx.gbl you wrote:
I don't know the normal procedure, if I should send the patch to Wolfgang o= r someone else, but I found a problem with Makefile and TQM5200 HIGHBOOT co= nfig in Makefile. I think this problem is also in previous versions since t= qm boards where moved under tqc folder.
Please use a line length not longer than some 70+ characters.
Sorry, you told me before and I forgot. I use web email and can not change this option, so I have to do it manually.
The patch is:
--- a/Makefile 2008-09-04 14:55:05.000000000 +0200 +++ b/Makefile 2008-09-04 14:56:14.000000000 +0200 @@ -755,7 +755,7 @@ echo "#define CONFIG_TQM5200_B" >>$(obj)include/config.h ; \ } @[ -z "$(findstring HIGHBOOT,$@)" ] || \
{ echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqm5200/config.tmp ; \
{ echo "TEXT_BASE =3D 0xFFF00000">$(obj)board/tqc/tqm5200/config.tmp ; \Please re-submit after adding your Signed-off-by: line (and please follow the other instructions Detlev sent you).
I'll do it as fast as I can. I can't submit from my office, so I need to do it from home and had no time these days.
Regards,
Pedro.
_________________________________________________________________ Llega la nueva temporada. Consulta las nuevas tendencias en MSN Estilo http://estilo.es.msn.com/moda/
participants (3)
-
Detlev Zundel -
Pedro Luis D. L. -
Wolfgang Denk