[PATCH] efi_loader: Fix Kconfig for EFI_TCG2 protocol
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So add the missing SHA1, SHA256, SHA384 and SHA512 we currently support as depenmdencies
Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org --- lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 0b99d7c7749b..6decdee6aa3e 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL config EFI_TCG2_PROTOCOL bool "EFI_TCG2_PROTOCOL support" depends on TPM_V2 + depends on SHA1 && SHA256 && SHA384 && SHA512 help Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware of the platform.
+CC Michal who actually noticed this.
Heinrich can you add a Reported-by: Michal Simek michal.simek@xilinx.com
before merging this? Or you prefer me to resend?
On Mon, 10 May 2021 at 21:26, Ilias Apalodimas ilias.apalodimas@linaro.org wrote:
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So add the missing SHA1, SHA256, SHA384 and SHA512 we currently support as depenmdencies
Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org
lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 0b99d7c7749b..6decdee6aa3e 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL config EFI_TCG2_PROTOCOL bool "EFI_TCG2_PROTOCOL support" depends on TPM_V2
depends on SHA1 && SHA256 && SHA384 && SHA512 help Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware of the platform.-- 2.31.0
On 10.05.21 20:26, Ilias Apalodimas wrote:
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So add the missing SHA1, SHA256, SHA384 and SHA512 we currently support as depenmdencies
Thanks for looking into the dependencies.
%s/depenmdencies/dependencies/
Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org
lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 0b99d7c7749b..6decdee6aa3e 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL config EFI_TCG2_PROTOCOL bool "EFI_TCG2_PROTOCOL support" depends on TPM_V2
Should we add default y?
- depends on SHA1 && SHA256 && SHA384 && SHA512
Would select make sense here?
select SHA1 select SHA256 select SHA512_ALGO select SHA384 select SHA512
Best regards
Heinrich
help Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware of the platform.
On Tue, May 11, 2021 at 09:25:04AM +0200, Heinrich Schuchardt wrote:
On 10.05.21 20:26, Ilias Apalodimas wrote:
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms. So add the missing SHA1, SHA256, SHA384 and SHA512 we currently support as depenmdencies
Thanks for looking into the dependencies.
%s/depenmdencies/dependencies/
Signed-off-by: Ilias Apalodimas ilias.apalodimas@linaro.org
lib/efi_loader/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig index 0b99d7c7749b..6decdee6aa3e 100644 --- a/lib/efi_loader/Kconfig +++ b/lib/efi_loader/Kconfig @@ -301,6 +301,7 @@ config EFI_RNG_PROTOCOL config EFI_TCG2_PROTOCOL bool "EFI_TCG2_PROTOCOL support" depends on TPM_V2
Should we add default y?
We could, the memory 'wasted' for the eventlog is 4kb so I don't think that's too much
- depends on SHA1 && SHA256 && SHA384 && SHA512
Would select make sense here?
select SHA1 select SHA256 select SHA512_ALGO select SHA384 select SHA512
Yea ti would, I can change it if you prefer it.
Cheers /Ilias
Best regards
Heinrich
help Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware of the platform.
participants (2)
-
Heinrich Schuchardt -
Ilias Apalodimas