[U-Boot-Users] tftp warning/error?
'TFTP: add host ip addr support' commit added this bit of code which seems bogus:
} else { char *p = strchr (p, ':');
Is this really correct?
- k
On 14:57 Wed 13 Feb , Kumar Gala wrote:
'TFTP: add host ip addr support' commit added this bit of code which seems bogus:
} else { char *p = strchr (p, ':');Is this really correct?
No, it this - char *p = strchr (p, ':'); + char *p = strchr (BootFile, ':');
Best Regards, J.
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/net/tftp.c b/net/tftp.c index 3dd2b06..ea8fea2 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -474,7 +474,7 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else { - char *p = strchr (p, ':'); + char *p = strchr (BootFile, ':');
if (p == NULL) { strncpy(tftp_filename, BootFile, MAX_LEN);
Wolfgang,
Can you pick this up as its a clear bug fix.
- k
On Feb 14, 2008, at 1:02 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/net/tftp.c b/net/tftp.c index 3dd2b06..ea8fea2 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -474,7 +474,7 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else {
char *p = strchr (p, ':');
char *p = strchr (BootFile, ':');if (p == NULL) { strncpy(tftp_filename, BootFile, MAX_LEN);
-- 1.5.3.7
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users
In message 1202972532-17372-1-git-send-email-plagnioj@jcrosoft.com you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/net/tftp.c b/net/tftp.c index 3dd2b06..ea8fea2 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -474,7 +474,7 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else {
char *p = strchr (p, ':');
char *p = strchr (BootFile, ':');
Applied, thanks.
Best regards,
Wolfgang Denk
In message 1202972532-17372-1-git-send-email-plagnioj@jcrosoft.com you wrote:
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com
diff --git a/net/tftp.c b/net/tftp.c index 3dd2b06..ea8fea2 100644 --- a/net/tftp.c +++ b/net/tftp.c @@ -474,7 +474,7 @@ TftpStart (void) printf ("*** Warning: no boot file name; using '%s'\n", tftp_filename); } else {
char *p = strchr (p, ':');
char *p = strchr (BootFile, ':');if (p == NULL) { strncpy(tftp_filename, BootFile, MAX_LEN);
Applied, thanks.
Best regards,
Wolfgang Denk
Kumar Gala wrote:
'TFTP: add host ip addr support' commit added this bit of code which seems bogus:
} else { char *p = strchr (p, ':');Is this really correct?
- k
That's F-d up. The patches I have are like this:
- tftp_filename = BootFile; + char *p=BootFile; + p = strchr (p, ':');
but never got pulled into the net branch. I guess Wolfgang must have pulled directly. C'mon patch management system!!!
cheers, Ben
participants (5)
-
Ben Warren -
Jean-Christophe PLAGNIOL-VILLARD -
Kumar Gala -
Kumar Gala -
Wolfgang Denk