[U-Boot-Users] [PATCH] M5282EVB - initdram() does not return a value
When working with a M5282EVB configuration I have noticed that initdram() (in /board/m5282evb/m5282evb.c) does not return a value. It should return the dram size. This causes U-Boot to be unable to complete it's boot process since dram size is set to some garbage value. The following patch fixes the problem:
Signed-off-by: Erez Koelewyn ekoelewyn@gmail.com
--- u-boot-1.3.0-rc3/board/m5282evb/m5282evb.c 2007-10-13 18:13:19.000000000-0400 +++ u-boot-1.3.0-rc3-modified/board/m5282evb/m5282evb.c 2007-10-16 10:00: 13.488093200 -0400 @@ -89,4 +89,6 @@ /* Write to the SDRAM Mode Register */ *(u32 *)(CFG_SDRAM_BASE + 0x400) = 0xA5A59696; } + + return dramsize; }
Regards,
Erez
In message 7fd1eb680710160734o22b42293l777463e13a2a14eb@mail.gmail.com you wrote:
--- u-boot-1.3.0-rc3/board/m5282evb/m5282evb.c 2007-10-13 18:13:19.000000000-0400 +++ u-boot-1.3.0-rc3-modified/board/m5282evb/m5282evb.c 2007-10-16 10:00: 13.488093200 -0400 @@ -89,4 +89,6 @@ /* Write to the SDRAM Mode Register */ *(u32 *)(CFG_SDRAM_BASE + 0x400) = 0xA5A59696; }
^^^^^^^^^^^^^^^^ All leading white space corrupted by your mailer.
Please fix your mailer configuration and resent.
Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline
And *never* send HTML here, please.
Best regards,
Wolfgang Denk
participants (2)
-
Erez Koelewyn -
Wolfgang Denk