[U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
Miss the SPI_FLASH_BAR for the ESPI controller of FSL.
Signed-off-by: Xiaowei Bao xiaowei.bao@nxp.com --- drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b8ca2bd..7003569 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -367,6 +367,7 @@ config CF_SPI
config FSL_ESPI bool "Freescale eSPI driver" + imply SPI_FLASH_BAR help Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Xiaowei Bao Sent: Monday, October 21, 2019 2:32 PM To: Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
configs: spi: -> spi: Kconfig
I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add
ESPI -> FSL_ESPI
Miss the SPI_FLASH_BAR for the ESPI controller of FSL.
Signed-off-by: Xiaowei Bao xiaowei.bao@nxp.com
drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b8ca2bd..7003569 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -367,6 +367,7 @@ config CF_SPI
config FSL_ESPI bool "Freescale eSPI driver"
- imply SPI_FLASH_BAR help Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
--
--priyankajain
-----Original Message----- From: Priyanka Jain priyanka.jain@nxp.com Sent: 2019年10月22日 17:45 To: Xiaowei Bao xiaowei.bao@nxp.com; Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Xiaowei Bao Sent: Monday, October 21, 2019 2:32 PM To: Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
configs: spi: -> spi: Kconfig
I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add
Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC board.
Thanks Xiaowei
ESPI -> FSL_ESPI
Miss the SPI_FLASH_BAR for the ESPI controller of FSL.
Signed-off-by: Xiaowei Bao xiaowei.bao@nxp.com
drivers/spi/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index b8ca2bd..7003569 100644 --- a/drivers/spi/Kconfig +++ b/drivers/spi/Kconfig @@ -367,6 +367,7 @@ config CF_SPI
config FSL_ESPI bool "Freescale eSPI driver"
- imply SPI_FLASH_BAR help Enable the Freescale eSPI driver. This driver can be used to access the SPI interface and SPI NOR flash on platforms embedding
--
--priyankajain
On Tue, Oct 22, 2019 at 3:21 PM Xiaowei Bao xiaowei.bao@nxp.com wrote:
-----Original Message----- From: Priyanka Jain priyanka.jain@nxp.com Sent: 2019年10月22日 17:45 To: Xiaowei Bao xiaowei.bao@nxp.com; Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Xiaowei Bao Sent: Monday, October 21, 2019 2:32 PM To: Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
configs: spi: -> spi: Kconfig
I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add
Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC board.
Did I miss while moving around? please mark the commit where it missed it would help to track where the issue comes from.
-----Original Message----- From: Jagan Teki jagan@amarulasolutions.com Sent: 2019年10月24日 3:40 To: Xiaowei Bao xiaowei.bao@nxp.com Cc: Priyanka Jain priyanka.jain@nxp.com; Jagdish Gediya jagdish.gediya@nxp.com; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
On Tue, Oct 22, 2019 at 3:21 PM Xiaowei Bao xiaowei.bao@nxp.com wrote:
-----Original Message----- From: Priyanka Jain priyanka.jain@nxp.com Sent: 2019年10月22日 17:45 To: Xiaowei Bao xiaowei.bao@nxp.com; Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: RE: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
-----Original Message----- From: U-Boot u-boot-bounces@lists.denx.de On Behalf Of Xiaowei Bao Sent: Monday, October 21, 2019 2:32 PM To: Jagdish Gediya jagdish.gediya@nxp.com; jagan@amarulasolutions.com; u-boot@lists.denx.de Cc: Xiaowei Bao xiaowei.bao@nxp.com Subject: [U-Boot] [PATCH] configs: spi: Miss the SPI_FLASH_BAR for ESPI
configs: spi: -> spi: Kconfig
I understand you are adding config, because you have missed it earlier. But better would be something like Miss->Add
Thanks for your comments, this CONFIG option is missed by Jagan Teki, so I add it in Kconfig file, otherwise, the ESPI will not work in some PPC
board.
Did I miss while moving around? please mark the commit where it missed it would help to track where the issue comes from.
Oh, sorry, it is missed by Vignesh R, the commit is 6d82517836418f984b7b4c05cf1427d7b49b1169
Thanks Xiaowei
participants (3)
-
Jagan Teki -
Priyanka Jain -
Xiaowei Bao