[U-Boot-Users] Patch fixes bug for clearing the bss section
Hi, There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S) In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.
This patch fixes this bug by putting bss_start into %edi register.
Author: Mushtaq Khan mushtaq_k@procsys.com Date: Thu Apr 30 15:40:45 2007 Signed-off-by: Mushtaq Khan mushtaq_k@procsys.com
diff -purN u-boot/cpu/i386/start.S u-boot_chg/cpu/i386/start.S --- u-boot/cpu/i386/start.S 2007-02-21 10:59:41.000000000 +0530 +++ u-boot_chg/cpu/i386/start.S 2007-04-30 14:51:48.000000000 +0530 @@ -149,7 +149,7 @@ data_ok: .progress3:
/* clear bss section in ram, size must be 4-byte aligned */ - movl $_i386boot_bss_start, %eax /* BSS start */ + movl $_i386boot_bss_start, %edi /* MK_CHG BSS start */ movl $_i386boot_bss_size, %ecx /* BSS size */ movl %ecx, %eax andl $3, %eax
In message 4635C48A.5050703@procsys.com you wrote:
Hi, There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S) In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.
This patch fixes this bug by putting bss_start into %edi register.
Applied to u-boot-testing.
Thanks.
Best regards,
Wolfgang Denk
Hi Wolfgang Denk,
Any issues with my Patches, SATA and clearing of bss section. Please update me.
Thanks, -Mushtaq
Wolfgang Denk wrote:
In message 4635C48A.5050703@procsys.com you wrote:
Hi, There is a bug in the code of clearing the bss section for processor i386.(File: cpu/i386/start.S) In the code, bss_start addr (starting addr of bss section) is put into the register %eax, but the code which clears the bss section refers to the addr pointed by %edi.
This patch fixes this bug by putting bss_start into %edi register.
Applied to u-boot-testing.
Thanks.
Best regards,
Wolfgang Denk
In message 4660188C.9070907@procsys.com you wrote:
Any issues with my Patches, SATA and clearing of bss section.Please update me.
I wrote:
Applied to u-boot-testing.
Did you test the code in the u-boot-testing repository? I did not receive any feedback from you (nor any form others).
Best regards,
Wolfgang Denk
Hi Wolfgang Denk,
I tested my patches in u-boot-testing 1. Clearing of bss section patch and 2. Sata patch.
Clearing of bss section patch has no issues. But with sata patch, got compilation warning: fuinction proto-type mismatch between block_read and sata_read.
This is becuase i had been working on u-boot downloaded on feb-15th. And on Apr-13th, patch "Fix use of "void *" for block dev read/write buffer pointers" has been applied, which has changed the proto-type of block_read function.
I will bring these changes to my patch. And after testing , i will re-submit the patch.
Thanks, -Mushtaq Khan.
Wolfgang Denk wrote:
In message 4660188C.9070907@procsys.com you wrote:
Any issues with my Patches, SATA and clearing of bss section. Please update me.
I wrote:
Applied to u-boot-testing.
Did you test the code in the u-boot-testing repository? I did not receive any feedback from you (nor any form others).
Best regards,
Wolfgang Denk
participants (2)
-
mushtaq khan -
Wolfgang Denk