[U-Boot] [PATCH] fix nfs symlink name corruption

An off by one error may cause nfs readlink lookup fail if nfs_path_buff has non-zero data from a previous use.
Loading: *** ERROR: File lookup fail
Signed-off-by: Ed Swarthout Ed.Swarthout@freescale.com --- net/nfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/nfs.c b/net/nfs.c index 27395fb..c39f616 100644 --- a/net/nfs.c +++ b/net/nfs.c @@ -516,7 +516,7 @@ nfs_readlink_reply (uchar *pkt, unsigned len) strcat (nfs_path, "/"); pathlen = strlen(nfs_path); memcpy (nfs_path+pathlen, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen); - nfs_path[pathlen+rlen+1] = 0; + nfs_path[pathlen + rlen] = 0; } else { memcpy (nfs_path, (uchar *)&(rpc_pkt.u.reply.data[2]), rlen); nfs_path[rlen] = 0;

Dear Ed Swarthout,
In message 1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com you wrote:
An off by one error may cause nfs readlink lookup fail if nfs_path_buff has non-zero data from a previous use.
Loading: *** ERROR: File lookup fail
Signed-off-by: Ed Swarthout Ed.Swarthout@freescale.com
net/nfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Ben, I hope this is OK with you. Looked obvious to me.
Best regards,
Wolfgang Denk

Wolfgang Denk wrote:
Dear Ed Swarthout,
In message 1258620448-20960-1-git-send-email-Ed.Swarthout@freescale.com you wrote:
An off by one error may cause nfs readlink lookup fail if nfs_path_buff has non-zero data from a previous use.
Loading: *** ERROR: File lookup fail
Signed-off-by: Ed Swarthout Ed.Swarthout@freescale.com
net/nfs.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Ben, I hope this is OK with you. Looked obvious to me.
Best regards,
Wolfgang Denk
Fine with me. Thanks for taking care of this.
Ben
participants (3)
-
Ben Warren
-
Ed Swarthout
-
Wolfgang Denk