Re: [U-Boot-Users] [patch] Added support for Embedded planetep85xxm board

Also, the patch set is sent as folders/files patches format.Seems not
conform to the rule of README.
Glad to see EP's contribution. This will make EP boards more acceptable
to customers.
Thanks, Sam
could someone please explain the patch format, because the README states:
-----QUOTE FROM README---- If you have modified U-Boot sources (for instance added a new board or support for new devices, a new CPU, etc.) you are expected to provide feedback to the other developers. The feedback normally takes the form of a "patch", i. e. a context diff against a certain (latest official or latest in CVS) version of U-Boot sources.
But before you submit such a patch, please verify that your modifi- cation did not break existing code. At least make sure that *ALL* of the supported boards compile WITHOUT ANY compiler warnings. To do so, just run the "MAKEALL" script.... See also "U-Boot Porting Guide" below..... .... U-Boot Porting Guide: .... [c style code joke] .... [style standards] .... Submitting Patches:.... .... * The patch itself. If you are accessing the CVS repository use "cvs update; cvs diff -puRN"; else, use "diff -purN OLD NEW". If your version of diff does not support these options, then get the latest version of GNU diff.
The current directory when running this command shall be the top level directory of the U-Boot source tree, or it's parent directory (i. e. please make sure that your patch includes sufficient directory information for the affected files). ------END QUOTE-----
This is how I interpreted "please make sure that your patch includes sufficient directory information for the affected files."
If that is incorrect, please correct me with more detailed instructions. I am reatltivly new to u-boot, so with helpful feedback I will be able to provide valuable contributions.
Thanks, JM
-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of Sam Song Sent: Monday, July 17, 2006 9:38 AM To: Li Yang-r58472; Jeff Mann Cc: u-boot-users@lists.sourceforge.net Subject: Re: [U-Boot-Users] [patch] Added support for Embedded planetep85xxm board
Li Yang-r58472 LeoLi@freescale.com wrote:
Just a remainder. The email address should be updated from motorola.com to freescale.com.
Best Regards, Leo

Jeff Mann MannJ@embeddedplanet.com wrote:
This is how I interpreted "please make sure that your patch includes sufficient directory information for the affected files."
If that is incorrect, please correct me with more detailed instructions. I am reatltivly new to u-boot, so with helpful feedback I will be able to provide valuable contributions.
I meant to suggest you create 85xx patch like 83xx patch you did for better review and apply [My poor experience]. Well, if W.D. think it is OK, that would be fine.
cvs diff -puRN or git diff cannot produce such a 85xx patch. I also wonder how to create such a result.
Thanks,
Sam
___________________________________________________________ 抢注雅虎免费邮箱-3.5G容量,20M附件! http://cn.mail.yahoo.com

In message 20060717143736.23897.qmail@web15902.mail.cnb.yahoo.com you wrote:
cvs diff -puRN or git diff cannot produce such a 85xx patch. I also wonder how to create such a result.
I have lost track of what you are discussion / complaining about. What exactly is your problem?
Best regards,
Wolfgang Denk

Wolfgang Denk wd@denx.de wrote:
cvs diff -puRN or git diff cannot produce such a 85xx patch. I also wonder how to create such a result.
I have lost track of what you are discussion / complaining about. What exactly is your problem?
Is this patch acceptable in format?
BTW, I want to know the skill how to produce and apply such a patch including folders. It is new to me in format.
Thanks,
Sam
__________________________________________________ 赶快注册雅虎超大容量免费邮箱? http://cn.mail.yahoo.com

In message 20060718135216.68727.qmail@web15901.mail.cnb.yahoo.com you wrote:
Is this patch acceptable in format?
No, it is not. It violates the patch submission rules as defined in the README, and it is basicly useless.
BTW, I want to know the skill how to produce and apply such a patch including folders. It is new to me in format.
You probably don't want to know as it's useless.
Best regards,
Wolfgang Denk
participants (3)
-
Jeff Mann
-
Sam Song
-
Wolfgang Denk