[U-Boot] [PATCH] cmd: Make CMD_USB_MASS_STORAGE visible only with USB_GADGET and default y

In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET enabled, so only show this option when USB_GADGET is set. In addition, expand the help text so it's clearer what this does and given the overall utility of this command, make it enabled by default.
Signed-off-by: Tom Rini trini@konsulko.com --- cmd/Kconfig | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig index d28da54ed659..ddbd5a82d80f 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -408,10 +408,14 @@ config CMD_DFU Enables the command "dfu" which is used to have U-Boot create a DFU class device via USB.
+if USB_GADGET config CMD_USB_MASS_STORAGE bool "UMS usb mass storage" + default y help - USB mass storage support + Enables the command "ums" which is used to have U-Boot expose + local storage such as eMMC as a USB Mass Storage Device class device. +endif
config CMD_FPGA bool "fpga"

On Mon, Sep 19, 2016 at 12:40:12PM -0400, Tom Rini wrote:
In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET enabled, so only show this option when USB_GADGET is set. In addition, expand the help text so it's clearer what this does and given the overall utility of this command, make it enabled by default.
Signed-off-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!

On Sat, Oct 08, 2016 at 01:06:26PM -0400, Tom Rini wrote:
On Mon, Sep 19, 2016 at 12:40:12PM -0400, Tom Rini wrote:
In order for CMD_USB_MASS_STORAGE to be useful we must have USB_GADGET enabled, so only show this option when USB_GADGET is set. In addition, expand the help text so it's clearer what this does and given the overall utility of this command, make it enabled by default.
Signed-off-by: Tom Rini trini@konsulko.com
Applied to u-boot/master, thanks!
No, no it's not. This needs a bit more work as it exposes some backend options that need to be migrated first, and it also needs to depend on USB_GADGET_DOWNLOAD being set as we need to have the IDs set and can't (well, shouldn't) force values there. So this is really a changes requested.
participants (1)
-
Tom Rini