[PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io --- arch/arm/dts/imx7ulp-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts index 08a682f314..8f6a935e24 100644 --- a/arch/arm/dts/imx7ulp-evk.dts +++ b/arch/arm/dts/imx7ulp-evk.dts @@ -156,7 +156,7 @@
pinctrl_backlight: backlight_grp { fsl,pins = < - IMX7ULP_PAD_PTF2__PTF2 0x20100 + IMX7ULP_PAD_PTF2__PTF2 0x20000 >; };
Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Has this been accepted by Shawn?
Thanks, Peng.
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io
arch/arm/dts/imx7ulp-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts index 08a682f314..8f6a935e24 100644 --- a/arch/arm/dts/imx7ulp-evk.dts +++ b/arch/arm/dts/imx7ulp-evk.dts @@ -156,7 +156,7 @@
pinctrl_backlight: backlight_grp { fsl,pins = <
IMX7ULP_PAD_PTF2__PTF2 0x20100
IMX7ULP_PAD_PTF2__PTF2 0x20000 >;-- 2.17.1
On 16/01/20 02:22:35, Peng Fan wrote:
Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Has this been accepted by Shawn?
added to DL now
Thanks, Peng.
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io
arch/arm/dts/imx7ulp-evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/dts/imx7ulp-evk.dts b/arch/arm/dts/imx7ulp-evk.dts index 08a682f314..8f6a935e24 100644 --- a/arch/arm/dts/imx7ulp-evk.dts +++ b/arch/arm/dts/imx7ulp-evk.dts @@ -156,7 +156,7 @@
pinctrl_backlight: backlight_grp { fsl,pins = <
IMX7ULP_PAD_PTF2__PTF2 0x20100
IMX7ULP_PAD_PTF2__PTF2 0x20000 >;-- 2.17.1
On Thu, Jan 16, 2020 at 4:40 AM Jorge Ramirez-Ortiz, Foundries jorge@foundries.io wrote:
On 16/01/20 02:22:35, Peng Fan wrote:
Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Has this been accepted by Shawn?
added to DL now
Mainline dts does not have backlight support, so this only affects U-Boot.
On 17/01/20 08:51:45, Fabio Estevam wrote:
On Thu, Jan 16, 2020 at 4:40 AM Jorge Ramirez-Ortiz, Foundries jorge@foundries.io wrote:
On 16/01/20 02:22:35, Peng Fan wrote:
Subject: [PATCH] arm: dts: imx7ulp-evk: remove mux value from pad configuration
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Has this been accepted by Shawn?
added to DL now
Mainline dts does not have backlight support, so this only affects U-Boot.
yes, the dts is only incorrect in uboot (ie, any of the mux values that could be specified in the pad configuration field are just ignored)
On Wed, Jan 15, 2020 at 2:50 PM Jorge Ramirez-Ortiz jorge@foundries.io wrote:
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied).
Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io
Reviewed-by: Fabio Estevam festevam@gmail.com
The mux mode is embedded in the PAD definition and therefore there is no need to repeat it in the PAD configuration value (more over since this information will be masked out when the configuration value is applied). Signed-off-by: Jorge Ramirez-Ortiz jorge@foundries.io Reviewed-by: Fabio Estevam festevam@gmail.com
Applied to u-boot-imx, master, thanks !
Best regards, Stefano Babic
participants (5)
-
Fabio Estevam -
Jorge Ramirez-Ortiz -
Jorge Ramirez-Ortiz, Foundries
-
Peng Fan -
sbabic＠denx.de