Re: [PATCH] Makefile: use shell to calculate map_size

Oops! That should have went to the list as well...
On Mon, 4 Mar 2024 15:40:07 +0100 Leon Busch-George leon@georgemail.eu wrote:
Hi Dragan :-)
Thanks for your reply!
On Sat, 02 Mar 2024 22:13:08 +0100 Dragan Simic dsimic@manjaro.org wrote:
awk '/_image_copy_start/ {start = $$1}
/_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "echo $$((0x" toupper(end) " - 0x" toupper(start) "))"}' \ | sed 's/0X//g' \
| bc); \
| sh); \
Maybe "sh -s" could be used instead, just for some additional strictness.
-s is the default already but I see no reason against adding it. Allow me to offer another idea to improve strictness (I'll send a v2):
awk '.. print end " " start ..' | sh -c 'read end start; echo
$((end - start))'
That gets rid off sed and the interface between awk and sh is much cleaner (only the two numbers on one line rather than shell code). Sadly, the sed 's/0X//g' was introduced without an explanation in 3ce7a4fefa and but, looking at it more, I'm farly confident it was only for bc.
kind regards, Leon
participants (1)
-
Leon Busch-George