Hi Massimo,

On 2023/9/3 18:04, Massimo Pegorer wrote:

Il giorno sab 2 set 2023 alle ore 18:32 Massimo Pegorer massimo.pegorer+oss@gmail.com ha scritto:

...

There is no support to initialize DRAM on RK3308 SoC using U-Boot TPL and therefore an external TPL binary must be used to generate a bootable u-boot-rockchip.bin image.

Imply ROCKCHIP_EXTERNAL_TPL by default for RK3308 builds. Remove useless TPL_SERIAL.

Signed-off-by: Massimo Pegorer massimo.pegorer+oss@gmail.com

arch/arm/mach-rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig index a279582f4f..e8584de258 100644 --- a/arch/arm/mach-rockchip/Kconfig +++ b/arch/arm/mach-rockchip/Kconfig @@ -159,6 +159,7 @@ config ROCKCHIP_RK3308 select SPL_ATF select SPL_ATF_NO_PLATFORM_PARAM select SPL_LOAD_FIT

•   imply ROCKCHIP_EXTERNAL_TPL
     imply ROCKCHIP_COMMON_BOARD
     imply SPL_ROCKCHIP_COMMON_BOARD
     imply SPL_CLK
  

@@ -166,7 +167,6 @@ config ROCKCHIP_RK3308 imply SPL_SYSCON imply SPL_RAM imply SPL_SERIAL

•   imply TPL_SERIAL
     imply SPL_SEPARATE_BSS
     help
       The Rockchip RK3308 is a ARM-based Soc which embedded with quad
  

-- 2.34.1

I've just noticed that Jonas followed a different approach for RK3568 and RK3588:

config ROCKCHIP_EXTERNAL_TPL bool "Use external TPL binary" default y if ROCKCHIP_RK3568 || ROCKCHIP_RK3588

You can add RK3308 to default y.

Thanks,

- Kever

Is any one preferred? I slightly prefer the one I've done, as it gives a terse picture of what a SoC select/imply in a single place. Of course I can change it in a V2, if Jonas way is preferred, and to have a single congruent way to do things.

Thanks. Regards, Massimo