[U-Boot] [PATCH] sandbox: cros_ec: fix uninitialized use of len

Building with gcc-5.2 raises this warning:
drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet: drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized] if (len < 0) ^
If the function process_cmd() is called with req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be returned uninitialized.
Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com
---
drivers/misc/cros_ec_sandbox.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/misc/cros_ec_sandbox.c b/drivers/misc/cros_ec_sandbox.c index 7509612..98f19a6 100644 --- a/drivers/misc/cros_ec_sandbox.c +++ b/drivers/misc/cros_ec_sandbox.c @@ -460,6 +460,7 @@ static int process_cmd(struct ec_state *ec, len = cros_ec_keyscan(ec, resp_data); break; case EC_CMD_ENTERING_MODE: + len = 0; break; default: printf(" ** Unknown EC command %#02x\n", req_hdr->command);

On 6 November 2015 at 05:15, Daniel Schwierzeck daniel.schwierzeck@gmail.com wrote:
Building with gcc-5.2 raises this warning:
drivers/misc/cros_ec_sandbox.c: In function cros_ec_sandbox_packet: drivers/misc/cros_ec_sandbox.c:483:5: warning: len may be used uninitialized in this function [-Wmaybe-uninitialized] if (len < 0) ^
If the function process_cmd() is called with req_hdr->command == EC_CMD_ENTERING_MODE, the value of len will be returned uninitialized.
Signed-off-by: Daniel Schwierzeck daniel.schwierzeck@gmail.com
drivers/misc/cros_ec_sandbox.c | 1 + 1 file changed, 1 insertion(+)
Acked-by: Simon Glass sjg@chromium.org
participants (2)
-
Daniel Schwierzeck
-
Simon Glass