[PATCH 1/1] sandbox: enable CMD_BOOTEFI_HELLO and CMD_EFIDEBUG

'bootefi hello' is used in one of the Python tests.
efidebug can be used to verify the correct initialization of the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de --- configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 2 ++ configs/sandbox_spl_defconfig | 2 ++ 4 files changed, 7 insertions(+)
diff --git a/configs/sandbox64_defconfig b/configs/sandbox64_defconfig index 71a4d7fccb..c03b425405 100644 --- a/configs/sandbox64_defconfig +++ b/configs/sandbox64_defconfig @@ -22,6 +22,7 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_CMD_CPU=y CONFIG_CMD_LICENSE=y CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTEFI_HELLO=y # CONFIG_CMD_ELF is not set CONFIG_CMD_ASKENV=y CONFIG_CMD_GREPENV=y @@ -53,6 +54,7 @@ CONFIG_CMD_DNS=y CONFIG_CMD_LINK_LOCAL=y CONFIG_CMD_ETHSW=y CONFIG_CMD_BMP=y +CONFIG_CMD_EFIDEBUG=y CONFIG_CMD_TIME=y CONFIG_CMD_TIMER=y CONFIG_CMD_SOUND=y diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index f96891ecae..78b09ba5f3 100644 --- a/configs/sandbox_defconfig +++ b/configs/sandbox_defconfig @@ -25,6 +25,7 @@ CONFIG_ANDROID_AB=y CONFIG_CMD_CPU=y CONFIG_CMD_LICENSE=y CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTEFI_HELLO=y CONFIG_CMD_ABOOTIMG=y # CONFIG_CMD_ELF is not set CONFIG_CMD_ASKENV=y diff --git a/configs/sandbox_flattree_defconfig b/configs/sandbox_flattree_defconfig index 43efefda51..6960da31a1 100644 --- a/configs/sandbox_flattree_defconfig +++ b/configs/sandbox_flattree_defconfig @@ -19,6 +19,7 @@ CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_CMD_CPU=y CONFIG_CMD_LICENSE=y CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTEFI_HELLO=y # CONFIG_CMD_ELF is not set CONFIG_CMD_ASKENV=y CONFIG_CMD_GREPENV=y @@ -43,6 +44,7 @@ CONFIG_CMD_CDP=y CONFIG_CMD_SNTP=y CONFIG_CMD_DNS=y CONFIG_CMD_LINK_LOCAL=y +CONFIG_CMD_EFIDEBUG=y CONFIG_CMD_TIME=y CONFIG_CMD_TIMER=y CONFIG_CMD_SOUND=y diff --git a/configs/sandbox_spl_defconfig b/configs/sandbox_spl_defconfig index cb387e744b..de22c27608 100644 --- a/configs/sandbox_spl_defconfig +++ b/configs/sandbox_spl_defconfig @@ -28,6 +28,7 @@ CONFIG_SPL_ENV_SUPPORT=y CONFIG_CMD_CPU=y CONFIG_CMD_LICENSE=y CONFIG_CMD_BOOTZ=y +CONFIG_CMD_BOOTEFI_HELLO=y # CONFIG_CMD_ELF is not set CONFIG_CMD_ASKENV=y CONFIG_CMD_GREPENV=y @@ -56,6 +57,7 @@ CONFIG_CMD_SNTP=y CONFIG_CMD_DNS=y CONFIG_CMD_LINK_LOCAL=y CONFIG_CMD_BMP=y +CONFIG_CMD_EFIDEBUG=y CONFIG_CMD_TIME=y CONFIG_CMD_TIMER=y CONFIG_CMD_SOUND=y -- 2.25.1

On Sat, 14 Mar 2020 at 05:27, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
'bootefi hello' is used in one of the Python tests.
efidebug can be used to verify the correct initialization of the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 2 ++ configs/sandbox_spl_defconfig | 2 ++ 4 files changed, 7 insertions(+)
I have to wonder if we should add this as an 'imply' in arch/Kconfig?
Reviewed-by: Simon Glass sjg@chromum.org

On 3/14/20 9:35 PM, Simon Glass wrote:
On Sat, 14 Mar 2020 at 05:27, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
'bootefi hello' is used in one of the Python tests.
efidebug can be used to verify the correct initialization of the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 2 ++ configs/sandbox_spl_defconfig | 2 ++ 4 files changed, 7 insertions(+)
I have to wonder if we should add this as an 'imply' in arch/Kconfig?
Thanks for reviewing.
I am fine with either way. Do you want me to resubmit with imply?
Best regards
Heinrich
Reviewed-by: Simon Glass sjg@chromum.org

Hi Heinrich,
On Sun, 15 Mar 2020 at 02:16, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 3/14/20 9:35 PM, Simon Glass wrote:
On Sat, 14 Mar 2020 at 05:27, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
'bootefi hello' is used in one of the Python tests.
efidebug can be used to verify the correct initialization of the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 2 ++ configs/sandbox_spl_defconfig | 2 ++ 4 files changed, 7 insertions(+)
I have to wonder if we should add this as an 'imply' in arch/Kconfig?
Thanks for reviewing.
I am fine with either way. Do you want me to resubmit with imply?
It's fine, we have a lot of these. Perhaps one day we should move common options to Kconfig.
Regards, Simon

Hi Heinrich,
On Sun, 15 Mar 2020 at 02:16, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
On 3/14/20 9:35 PM, Simon Glass wrote:
On Sat, 14 Mar 2020 at 05:27, Heinrich Schuchardt xypron.glpk@gmx.de wrote:
'bootefi hello' is used in one of the Python tests.
efidebug can be used to verify the correct initialization of the UEFI sub-system.
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
configs/sandbox64_defconfig | 2 ++ configs/sandbox_defconfig | 1 + configs/sandbox_flattree_defconfig | 2 ++ configs/sandbox_spl_defconfig | 2 ++ 4 files changed, 7 insertions(+)
I have to wonder if we should add this as an 'imply' in arch/Kconfig?
Thanks for reviewing.
I am fine with either way. Do you want me to resubmit with imply?
It's fine, we have a lot of these. Perhaps one day we should move common options to Kconfig.
Regards, Simon
Applied to u-boot-dm/next, thanks!
participants (3)
-
Heinrich Schuchardt
-
Simon Glass
-
sjg@google.com