[U-Boot-Users] RFC: do_reset for MCF5329/MCF537x

Hi list,
I just noticed a problem in the current git tree for Coldfire MCF532x/537x.
The function do_reset relies on the watchdog, which is not available if it is switched off.
Is there any objection against using the soft reset of the reset control module like this? (The bits are currently not defined in the header files, but of course could be added for readability.)
int do_reset(cmd_tbl_t * cmdtp, bd_t * bd, int flag, int argc, char *argv[]) { volatile ccm_t *ccmp = (ccm_t *) (MMAP_CCM);
ccmp->rstctrl = 0xc0; /* MCF_RCM_RCR_SOFTRST | MCF_RCM_RCR_FRCRSTOUT */
/* we don't return! */ return 0; };
Best regards, Wolfgang

Wolfgang,
Done! It is in the u-boot-coldfire.
Regards, TsiChung
-----Original Message----- From: u-boot-users-bounces@lists.sourceforge.net [mailto:u-boot-users-bounces@lists.sourceforge.net] On Behalf Of w.wegner@astro-kom.de Sent: Friday, October 26, 2007 10:39 AM To: u-boot-users@lists.sourceforge.net Subject: [U-Boot-Users] RFC: do_reset for MCF5329/MCF537x
Hi list,
I just noticed a problem in the current git tree for Coldfire MCF532x/537x.
The function do_reset relies on the watchdog, which is not available if it is switched off.
Is there any objection against using the soft reset of the reset control module like this? (The bits are currently not defined in the header files, but of course could be added for readability.)
int do_reset(cmd_tbl_t * cmdtp, bd_t * bd, int flag, int argc, char *argv[]) { volatile ccm_t *ccmp = (ccm_t *) (MMAP_CCM);
ccmp->rstctrl = 0xc0; /* MCF_RCM_RCR_SOFTRST | MCF_RCM_RCR_FRCRSTOUT */
/* we don't return! */ return 0; };
Best regards, Wolfgang
------------------------------------------------------------------------ - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ U-Boot-Users mailing list U-Boot-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/u-boot-users

In message 4791E710007FEB4BBF83775D787F462F051181C7@az33exm22.fsl.freescale.net you wrote:
Done! It is in the u-boot-coldfire.
If you mean I should pull from the CF repository, can you please send a formal pull request to the mailing list? Thanks.
Best regards,
Wolfgang Denk
participants (3)
-
Liew Tsi Chung
-
w.wegner@astro-kom.de
-
Wolfgang Denk