Please pull u-boot-dm (take 3)
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
---------------------------------------------------------------- patman snake-case conversion binman fit improvements ACPI fixes and making MCFG available to ARM
---------------------------------------------------------------- Alper Nebi Yasak (4): binman: Fix subentry expansion for FIT entry type binman: Register and check bintools from FIT subentries binman: Check missing bintools of Section subclasses binman: Convert FIT entry type to a subclass of Section entry type
Heiko Schocher (2): serial: remove nulldev_serial_input serial-uclass: fix build warning
Heinrich Schuchardt (1): sandbox: fix build failure with musl and SDL
Moritz Fischer (2): arch: x86: lib: acpi_table: Fix MCFG entries acpi: Move MCFG implementation to common lib
Rasmus Villemoes (1): dts: automatically build necessary .dtb files
Simon Glass (16): patman: Convert camel case in tools.py patman: Convert camel case in command.py patman: Convert camel case in checkpatch.py patman: Convert camel case in commit.py patman: Convert camel case in cros_subprocess.py patman: Convert camel case in func_test.py patman: Convert camel case in get_maintainer.py patman: Convert camel case in gitutil.py patman: Convert camel case in project.py patman: Convert camel case in test_checkpatch.py patman: Convert camel case in test_util.py patman: Convert camel case in tout.py patman: Rename Print() to Tprint() patman: Rename Color() method to build() patman: Convert camel case in terminal.py patman: Update with new pylint scores
Sughosh Ganu (1): dm: Use parenthesis for the device_get_ops macro argument
arch/arc/dts/Makefile | 2 + arch/arm/dts/Makefile | 2 + arch/m68k/dts/Makefile | 2 + arch/microblaze/dts/Makefile | 2 + arch/mips/dts/Makefile | 2 + arch/nds32/dts/Makefile | 2 + arch/nios2/dts/Makefile | 2 + arch/powerpc/dts/Makefile | 2 + arch/riscv/dts/Makefile | 2 + arch/sandbox/Makefile | 7 + arch/sandbox/cpu/Makefile | 11 +- arch/sandbox/dts/Makefile | 2 + arch/sh/dts/Makefile | 2 + arch/x86/cpu/intel_common/acpi.c | 15 +- arch/x86/cpu/tangier/acpi.c | 11 +- arch/x86/dts/Makefile | 2 + arch/x86/include/asm/acpi_table.h | 1 - arch/x86/lib/acpi_table.c | 52 ------- arch/xtensa/dts/Makefile | 2 + drivers/serial/serial-uclass.c | 2 +- drivers/serial/serial_nulldev.c | 5 - dts/Kconfig | 8 +- include/dm/device.h | 2 +- lib/acpi/Makefile | 1 + lib/acpi/mcfg.c | 64 ++++++++ scripts/Makefile.dts | 3 + scripts/pylint.base | 34 ++--- tools/binman/bintool.py | 30 ++-- tools/binman/bintool_test.py | 34 ++--- tools/binman/btool/lz4.py | 8 +- tools/binman/btool/lzma_alone.py | 16 +- tools/binman/cbfs_util.py | 12 +- tools/binman/cbfs_util_test.py | 20 +-- tools/binman/control.py | 74 +++++----- tools/binman/elf.py | 20 +-- tools/binman/elf_test.py | 20 +-- tools/binman/entry.py | 42 +++--- tools/binman/entry_test.py | 4 +- tools/binman/etype/atf_fip.py | 2 +- tools/binman/etype/blob.py | 4 +- tools/binman/etype/blob_ext_list.py | 2 +- tools/binman/etype/fdtmap.py | 2 +- tools/binman/etype/files.py | 2 +- tools/binman/etype/fill.py | 2 +- tools/binman/etype/fit.py | 77 +++++----- tools/binman/etype/fmap.py | 6 +- tools/binman/etype/gbb.py | 10 +- tools/binman/etype/intel_ifwi.py | 12 +- tools/binman/etype/mkimage.py | 8 +- tools/binman/etype/section.py | 27 ++-- tools/binman/etype/text.py | 4 +- tools/binman/etype/u_boot_elf.py | 6 +- tools/binman/etype/u_boot_env.py | 4 +- tools/binman/etype/u_boot_spl_bss_pad.py | 4 +- tools/binman/etype/u_boot_spl_expanded.py | 2 +- tools/binman/etype/u_boot_tpl_bss_pad.py | 4 +- tools/binman/etype/u_boot_tpl_expanded.py | 2 +- tools/binman/etype/u_boot_ucode.py | 4 +- tools/binman/etype/u_boot_with_ucode_ptr.py | 2 +- tools/binman/etype/vblock.py | 10 +- tools/binman/fdt_test.py | 4 +- tools/binman/fip_util.py | 16 +- tools/binman/fip_util_test.py | 36 ++--- tools/binman/fmap_util.py | 2 +- tools/binman/ftest.py | 383 +++++++++++++++++++++++++++--------------------- tools/binman/image.py | 16 +- tools/binman/main.py | 6 +- tools/binman/state.py | 34 ++--- tools/binman/test/220_fit_subentry_bintool.dts | 39 +++++ tools/buildman/builder.py | 108 +++++++------- tools/buildman/builderthread.py | 12 +- tools/buildman/control.py | 46 +++--- tools/buildman/func_test.py | 20 +-- tools/buildman/main.py | 4 +- tools/buildman/test.py | 30 ++-- tools/buildman/toolchain.py | 26 ++-- tools/dtoc/fdt.py | 4 +- tools/dtoc/fdt_util.py | 12 +- tools/dtoc/main.py | 6 +- tools/dtoc/test_dtoc.py | 76 +++++----- tools/dtoc/test_fdt.py | 34 ++--- tools/dtoc/test_src_scan.py | 12 +- tools/patman/checkpatch.py | 36 ++--- tools/patman/command.py | 30 ++-- tools/patman/commit.py | 10 +- tools/patman/control.py | 20 +-- tools/patman/cros_subprocess.py | 59 ++++---- tools/patman/func_test.py | 74 +++++----- tools/patman/get_maintainer.py | 8 +- tools/patman/gitutil.py | 176 +++++++++++----------- tools/patman/main.py | 10 +- tools/patman/patchstream.py | 12 +- tools/patman/project.py | 4 +- tools/patman/series.py | 32 ++-- tools/patman/settings.py | 4 +- tools/patman/status.py | 22 +-- tools/patman/terminal.py | 56 +++---- tools/patman/test_checkpatch.py | 80 +++++----- tools/patman/test_util.py | 10 +- tools/patman/tools.py | 86 +++++------ tools/patman/tout.py | 58 ++++---- tools/rmboard.py | 16 +- 102 files changed, 1290 insertions(+), 1157 deletions(-) create mode 100644 lib/acpi/mcfg.c create mode 100644 scripts/Makefile.dts create mode 100644 tools/binman/test/220_fit_subentry_bintool.dts
Regards, Simon
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Hi Tom,
On Thu, 10 Feb 2022 at 13:08, Tom Rini trini@konsulko.com wrote:
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Do you mean fail when the numbers go down?
Regards, Simon
On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:08, Tom Rini trini@konsulko.com wrote:
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Do you mean fail when the numbers go down?
No, it fails today when the numbers go down, like this PR did. Or would have if I didn't just ignore it and accept the lower number because the code was cleaned up. I mean is there some way to get pylint to say "this code has serious violations" and non-zero exit rather than just assign the code a numeric grade?
Hi Tom,
On Thu, 10 Feb 2022 at 13:40, Tom Rini trini@konsulko.com wrote:
On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:08, Tom Rini trini@konsulko.com wrote:
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Do you mean fail when the numbers go down?
No, it fails today when the numbers go down, like this PR did. Or would have if I didn't just ignore it and accept the lower number because the code was cleaned up. I mean is there some way to get pylint to say "this code has serious violations" and non-zero exit rather than just assign the code a numeric grade?
pylint is one of the world's slowest programs. We run in parallel on each file to keep the run time bearable.
The return code for individual pylint processes is generally non-zero, unless we happen to get a score of 10. We could use --fail-under but that seems to fail often enough even if the score is exactly equal to the value provided (i.e. we need to subtract 0.01).
We could add pylint checking to gitlab and 'make check' since it does at least provide a list of files which have got worse.
As to 'serious violations', there are already a lot. There is a flag to only consider certain classes of violations, but for now we cannot turn that on. Perhaps that should be a first step?
Regards, Simon
On Thu, Feb 10, 2022 at 02:01:21PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:40, Tom Rini trini@konsulko.com wrote:
On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:08, Tom Rini trini@konsulko.com wrote:
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Do you mean fail when the numbers go down?
No, it fails today when the numbers go down, like this PR did. Or would have if I didn't just ignore it and accept the lower number because the code was cleaned up. I mean is there some way to get pylint to say "this code has serious violations" and non-zero exit rather than just assign the code a numeric grade?
pylint is one of the world's slowest programs. We run in parallel on each file to keep the run time bearable.
The return code for individual pylint processes is generally non-zero, unless we happen to get a score of 10. We could use --fail-under but that seems to fail often enough even if the score is exactly equal to the value provided (i.e. we need to subtract 0.01).
We could add pylint checking to gitlab and 'make check' since it does at least provide a list of files which have got worse.
As to 'serious violations', there are already a lot. There is a flag to only consider certain classes of violations, but for now we cannot turn that on. Perhaps that should be a first step?
Yeah, OK. I'd like to focus on fixing the serious violations, make that a CI check and let any other cleanups be up to the script authors as time permits, rather than within CI. Maybe we keep pylint.base, but update it per release and it's more informative than basis for pass/fail on changes.
Regards, Simon
Hi Tom,
On Thu, 10 Feb 2022 at 14:20, Tom Rini trini@konsulko.com wrote:
On Thu, Feb 10, 2022 at 02:01:21PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:40, Tom Rini trini@konsulko.com wrote:
On Thu, Feb 10, 2022 at 01:23:36PM -0700, Simon Glass wrote:
Hi Tom,
On Thu, 10 Feb 2022 at 13:08, Tom Rini trini@konsulko.com wrote:
On Wed, Feb 09, 2022 at 12:52:02PM -0700, Simon Glass wrote:
Hi Tom,
This just drops off the final patch of 'take 2' since that is being reworked.
running here:
https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10936
The following changes since commit 859703251251d9567f29ab10c0a29f98eb0aff5c:
Merge branch '2022-02-08-Kconfig-updates' (2022-02-09 09:29:07 -0500)
are available in the Git repository at:
git://git.denx.de/u-boot-dm.git tags/dm-pull-8feb22-take3
for you to fetch changes up to f3078d4ea707931c2307a623ecf6e4d215b413d5:
binman: Convert FIT entry type to a subclass of Section entry type (2022-02-09 12:30:13 -0700)
So first, applied to u-boot/master. But I still had to re-generate scripts/pylint.base, and some numbers went down, but the code is cleaner. Can we just make pylint fail when there's serious errors with the code perhaps?
Do you mean fail when the numbers go down?
No, it fails today when the numbers go down, like this PR did. Or would have if I didn't just ignore it and accept the lower number because the code was cleaned up. I mean is there some way to get pylint to say "this code has serious violations" and non-zero exit rather than just assign the code a numeric grade?
pylint is one of the world's slowest programs. We run in parallel on each file to keep the run time bearable.
The return code for individual pylint processes is generally non-zero, unless we happen to get a score of 10. We could use --fail-under but that seems to fail often enough even if the score is exactly equal to the value provided (i.e. we need to subtract 0.01).
We could add pylint checking to gitlab and 'make check' since it does at least provide a list of files which have got worse.
As to 'serious violations', there are already a lot. There is a flag to only consider certain classes of violations, but for now we cannot turn that on. Perhaps that should be a first step?
Yeah, OK. I'd like to focus on fixing the serious violations, make that a CI check and let any other cleanups be up to the script authors as time permits, rather than within CI. Maybe we keep pylint.base, but update it per release and it's more informative than basis for pass/fail on changes.
OK I'll see if I can fix the errors (-E flag)
Regards, Simon
participants (2)
-
Simon Glass -
Tom Rini