Re: [U-Boot] [PATCH V2 1/3] Initial support for Marvell Orion5x SoC
-----Original Message----- From: Prafulla Wadaskar Sent: Wednesday, December 23, 2009 11:32 AM To: 'Wolfgang Denk'; Albert ARIBAUD Cc: U-Boot@lists.denx.de Subject: RE: [U-Boot] [PATCH V2 1/3] Initial support for Marvell Orion5x SoC
-----Original Message----- From: Wolfgang Denk [mailto:wd@denx.de] Sent: Saturday, December 05, 2009 6:08 AM To: Albert ARIBAUD Cc: U-Boot@lists.denx.de; Prafulla Wadaskar Subject: Re: [U-Boot] [PATCH V2 1/3] Initial support for Marvell Orion5x SoC
Dear Albert ARIBAUD,
In message 4B1236F3.4010605@free.fr you wrote:
These files are derived from their kirkwood counterparts,
which are GPL
v2 only, so I don't have the right to simply change that to
"v2 or any
later version", I believe, unless the originals' copyright
owner allows
it (and possibly even fixes the originals). Prafulla, would
you ACK this?
Ack
Indeed. These files need to be fixed ASAP, too:
drivers/gpio/kw_gpio.c drivers/i2c/kirkwood_i2c.c include/asm-arm/arch-kirkwood/gpio.h include/asm-arm/arch-kirkwood/mpp.h
In the kirkwood port these files are Imported from Linux kernel source, I will request the respective writers to update to latest GPL license.
I got a GREEN flag from respective owners, we can update these files for GPL v2, I will send the patch soon. Hi Albert, you also take care of the same in your patches
Regards.. Prafulla . .
Regards.. Prafulla . .
Prafulla Wadaskar a écrit :
I got a GREEN flag from respective owners, we can update these files for GPL v2, I will send the patch soon. Hi Albert, you also take care of the same in your patches
Regards.. Prafulla . .
Thanks Prafulla. I'll send out a V4 (yes...) patch set with these fixes plus the correction to memory size functions requested by Wolfgang. These will be the only two changes in V4 wrt V3 since apparently no other comment was made on the V3 patch set.
Amicalement,
Albert ARIBAUD a écrit :
Prafulla Wadaskar a écrit :
I got a GREEN flag from respective owners, we can update these files for GPL v2, I will send the patch soon. Hi Albert, you also take care of the same in your patches
Regards.. Prafulla . .
Thanks Prafulla. I'll send out a V4 (yes...) patch set with these fixes plus the correction to memory size functions requested by Wolfgang. These will be the only two changes in V4 wrt V3 since apparently no other comment was made on the V3 patch set.
Actually in my patch the the GPLv2-only files were gpio/mpp support files. As Wolfgang was not keen on yet-another-GPIO-API and anyway the gpio/mpp settings are fixed for the board(s) I am intending to support, I removed the APIs in patch V3 and directly set the register values in low level init. Therefore the GPLv2-only issue should not affect my patch any more. V4 will only contain the memory size fix requested by Wolfgang (along with typo fixes in e-mail addresses).
Amicalement,
participants (2)
-
Albert ARIBAUD -
Prafulla Wadaskar