[U-Boot] [PATCH] tools/mrvl_uart.sh: Tidy script output
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes: eee4835d22 ("tools: Add Marvell recovery image download script") Cc: Konstantin Porotchkin kostap@marvell.com Cc: Stefan Roese sr@denx.de Cc: Igal Liberman igall@marvell.com Signed-off-by: Andreas Färber afaerber@suse.de --- tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index 500fa117eb..6824208902 100755 --- a/tools/mrvl_uart.sh +++ b/tools/mrvl_uart.sh @@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]" - echo -e "\tport - serial port the target board connected to" + echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING=====" - echo -e "- The speed-up option is not awailable in SoC families prior to A8K+" + echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file
-# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate
# Optional - fire up Minicom
-----Original Message----- From: Andreas Färber [mailto:afaerber@suse.de] Sent: Saturday, January 20, 2018 14:19 To: u-boot@lists.denx.de Cc: Andreas Färber; Kostya Porotchkin; Stefan Roese; Igal Liberman Subject: [PATCH] tools/mrvl_uart.sh: Tidy script output
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes: eee4835d22 ("tools: Add Marvell recovery image download script") Cc: Konstantin Porotchkin kostap@marvell.com Cc: Stefan Roese sr@denx.de Cc: Igal Liberman igall@marvell.com Signed-off-by: Andreas Färber afaerber@suse.de
tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index 500fa117eb..6824208902 100755 --- a/tools/mrvl_uart.sh +++ b/tools/mrvl_uart.sh @@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]"
- echo -e "\tport - serial port the target board connected to"
- echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed
by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING====="
- echo -e "- The speed-up option is not awailable in SoC families
prior to A8K+"
- echo -e "- The speed-up option is not available in SoC families
prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx - vv $file > $port < $port #sx-at91 $port $file
-# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate
# Optional - fire up Minicom
2.13.6
[Konstantin Porotchkin] Reviewed-by: Konstantin Porotchkin kostap@marvell.com
On 20.01.2018 13:18, Andreas Färber wrote:
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes: eee4835d22 ("tools: Add Marvell recovery image download script") Cc: Konstantin Porotchkin kostap@marvell.com Cc: Stefan Roese sr@denx.de Cc: Igal Liberman igall@marvell.com Signed-off-by: Andreas Färber afaerber@suse.de
tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index 500fa117eb..6824208902 100755 --- a/tools/mrvl_uart.sh +++ b/tools/mrvl_uart.sh @@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]"
- echo -e "\tport - serial port the target board connected to"
- echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING====="
- echo -e "- The speed-up option is not awailable in SoC families prior to A8K+"
- echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file
-# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate
# Optional - fire up Minicom
Reviewed-by: Stefan Roese sr@denx.de
Thanks, Stefan
On 20.01.2018 13:18, Andreas Färber wrote:
Fix a typo in help output (awailable -> available). Tidy the grammar - not the board connects to a port, we do.
While at it, be consistent in upper-casing the comments.
Fixes: eee4835d22 ("tools: Add Marvell recovery image download script") Cc: Konstantin Porotchkin kostap@marvell.com Cc: Stefan Roese sr@denx.de Cc: Igal Liberman igall@marvell.com Signed-off-by: Andreas Färber afaerber@suse.de
tools/mrvl_uart.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/mrvl_uart.sh b/tools/mrvl_uart.sh index 500fa117eb..6824208902 100755 --- a/tools/mrvl_uart.sh +++ b/tools/mrvl_uart.sh @@ -46,13 +46,13 @@ then echo -e "\nMarvell recovery image downloader for Armada SoC family." echo -e "Command syntax:" echo -e "\t$(basename $0) <port> <file> [2|4|8]"
- echo -e "\tport - serial port the target board connected to"
- echo -e "\tport - serial port the target board is connected to" echo -e "\tfile - recovery boot image for target download" echo -e "\t2|4|8 - times to increase the default serial port speed by" echo -e "For example - load the image over ttyUSB0 @ 460800 baud:" echo -e "$(basename $0) /dev/ttyUSB0 /tmp/flash-image.bin 4\n" echo -e "=====WARNING====="
- echo -e "- The speed-up option is not awailable in SoC families prior to A8K+"
- echo -e "- The speed-up option is not available in SoC families prior to A8K+" echo -e "- This utility is not compatible with Armada 37xx SoC family\n" fi
@@ -111,7 +111,7 @@ stty -F $port raw ignbrk time 5 $fast_baudrate sx -vv $file > $port < $port #sx-at91 $port $file
-# return the port to the default speed +# Return the port to the default speed stty -F $port raw ignbrk time 5 $default_baudrate
# Optional - fire up Minicom
Applied to u-boot-marvell/master.
Thanks, Stefan
participants (3)
-
Andreas Färber -
Kostya Porotchkin -
Stefan Roese