[U-Boot] u-boot/master slight regression with trats
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ‘do_fat_fswrite’: cmd_fat.c:178:8: warning: unused variable ‘ep’ [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning: cmd_fat.c: In function 'do_fat_fswrite': cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]
Fix it.
Signed-off-by: Anatolij Gustschin agust@denx.de --- common/cmd_fat.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/common/cmd_fat.c b/common/cmd_fat.c index 55585c6..5a5698b 100644 --- a/common/cmd_fat.c +++ b/common/cmd_fat.c @@ -175,7 +175,6 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag, disk_partition_t info; int dev = 0; int part = 1; - char *ep;
if (argc < 5) return cmd_usage(cmdtp);
On Sat, 29 Sep 2012 12:52:55 +0200 Anatolij Gustschin agust@denx.de wrote:
Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning: cmd_fat.c: In function 'do_fat_fswrite': cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]
Fix it.
Signed-off-by: Anatolij Gustschin agust@denx.de
common/cmd_fat.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Reported-by: Albert ARIBAUD albert.u.boot@aribaud.net
I forgot to add attribution tag, so resending. patchwork hopefully will add it when picking the patch.
Thanks, Anatolij
Hi Anatolij,
On Sat, 29 Sep 2012 13:14:13 +0200, Anatolij Gustschin agust@denx.de wrote:
On Sat, 29 Sep 2012 12:52:55 +0200 Anatolij Gustschin agust@denx.de wrote:
Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning: cmd_fat.c: In function 'do_fat_fswrite': cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]
Fix it.
Signed-off-by: Anatolij Gustschin agust@denx.de
common/cmd_fat.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Reported-by: Albert ARIBAUD albert.u.boot@aribaud.net
I forgot to add attribution tag, so resending. patchwork hopefully will add it when picking the patch.
For the record, it fixes the build issue. As the fix is trivial,
Tested-by: Albert ARIBAUD albert.u.boot@aribaud.net
Thanks, Anatolij
Amicalement,
On Sat, Sep 29, 2012 at 12:52:55PM +0200, Anatolij Gustschin wrote:
Commit cfda5aeab89d73779e26f0d34cf10f64caa67431 (cmd_fat: use common get_device_and_partition function) introduced a warning: cmd_fat.c: In function 'do_fat_fswrite': cmd_fat.c:178:8: warning: unused variable 'ep' [-Wunused-variable]
Fix it.
Signed-off-by: Anatolij Gustschin agust@denx.de
Applied to u-boot/master, thanks (and patchwork picked up the tags)!
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ‘do_fat_fswrite’: cmd_fat.c:178:8: warning: unused variable ‘ep’ [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
BTW, I'm not sure who should take your patch as a custodian, but my take is, as the issue is now in u-boot/master, its fix could be applied directly to u-boot/master. Tom?
Amicalement,
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ‘do_fat_fswrite’: cmd_fat.c:178:8: warning: unused variable ‘ep’ [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
Thanks, Anatolij
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ‘do_fat_fswrite’: cmd_fat.c:178:8: warning: unused variable ‘ep’ [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
Hi Lukasz,
On Mon, 01 Oct 2012 11:21:59 +0200 Lukasz Majewski l.majewski@samsung.com wrote: ...
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
Please note that Tom applied a warning fix into git://git.denx.de/u-boot.git master
Thanks, Anatolij
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ‘do_fat_fswrite’: cmd_fat.c:178:8: warning: unused variable ‘ep’ [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )
It builds without errors/warinigs
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
On Mon, Oct 01, 2012 at 12:25:34PM +0200, Lukasz Majewski wrote:
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ???do_fat_fswrite???: cmd_fat.c:178:8: warning: unused variable ???ep??? [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )
It builds without errors/warinigs
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!
Hi Tom,
On Mon, Oct 01, 2012 at 12:25:34PM +0200, Lukasz Majewski wrote:
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hello,
While merging u-boot-arm/master and u-boot/master I have noticed one slight regression apparently coming from u-boot:
$ cat LOG/trats.ERR cmd_fat.c: In function ???do_fat_fswrite???: cmd_fat.c:178:8: warning: unused variable ???ep??? [-Wunused-variable]
ep should have disappeared along with the code which used it, but somehow resurfaced (I suspect it did in a merge).
This warning is not seen in u-boot-arm.
Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )
It builds without errors/warinigs
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!
I can serve as a maintainer for the board - I posses one and I actively develop and test code for it. No problem with that.
On 10/2/12, Lukasz Majewski l.majewski@samsung.com wrote:
Hi Tom,
On Mon, Oct 01, 2012 at 12:25:34PM +0200, Lukasz Majewski wrote:
Hi all,
On Sat, 29 Sep 2012 17:17:48 +0200 Albert ARIBAUD albert.u.boot@aribaud.net wrote:
Hi all,
On Sat, 29 Sep 2012 12:32:36 +0200, Albert ARIBAUD albert.u.boot@aribaud.net wrote:
> Hello, > > While merging u-boot-arm/master and u-boot/master I have > noticed one slight regression apparently coming from u-boot: > > $ cat LOG/trats.ERR > cmd_fat.c: In function ???do_fat_fswrite???: > cmd_fat.c:178:8: warning: unused variable > ???ep??? [-Wunused-variable] > > ep should have disappeared along with the code which used > it, but somehow resurfaced (I suspect it did in a merge). > > This warning is not seen in u-boot-arm. > > Amicalement,
Seems Heungjun Kim riverful.kim@samsung.com is now a dead address.
Anatolij, I see you've sent out a patch. Does it mean you would act as a maintainer for trats? Otherwise the board should be made orphan.
Dear all, I was on a holidays :-).
I can test if Trats is working. I posses one, so there is no problem with that :-).
I will fix Trats ASAP.
I've just tested TRATS with the newest origin/master (SHA1: 4668a086bb0a769b741e3a4ffab85f1c41c7cdb8 )
It builds without errors/warinigs
I do not have a trats board, so I can't do tests and act as a maintainer for it. Lukasz (on Cc) recently submitted some patches for trats, maybe he knows who could become new maintainer for trats board?
Ah, but would you be willing to take the MAINTAINER spot for the board? Thanks!
I can serve as a maintainer for the board - I posses one and I actively develop and test code for it. No problem with that.
Acked-by: Kyungmin Park kyungmin.park@samsung.com
Note that Mr. Kim left the company and Lukasz can take over trats board support.
Thank you, Kyungmin Park
-- Best regards,
Lukasz Majewski
Samsung Poland R&D Center | Linux Platform Group _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com --- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS index aa54fe1..eb96035 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -727,7 +727,7 @@ Chander Kashyap k.chander@samsung.com SMDKV310 ARM ARMV7 (EXYNOS4210 SoC) SMDK5250 ARM ARMV7 (EXYNOS5250 SoC)
-Heungjun Kim riverful.kim@samsung.com +Lukasz Majewski l.majewski@samsung.com
trats ARM ARMV7 (EXYNOS4210 SoC)
On Tue, Oct 02, 2012 at 06:32:07AM -0000, Lukasz Majewski wrote:
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com
MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot/master, thanks!
Dear Tom and Lukasz,
On 3 October 2012 07:07, Tom Rini trini@ti.com wrote:
On Tue, Oct 02, 2012 at 06:32:07AM -0000, Lukasz Majewski wrote:
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com
MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot/master, thanks!
We need to keep this list to Alphabetical. So, Lukasz's name should be moved to "M" section.
Thanks. Minkyu Kang.
participants (6)
-
Albert ARIBAUD -
Anatolij Gustschin -
Kyungmin Park -
Lukasz Majewski -
Minkyu Kang -
Tom Rini