[U-Boot] [PATCH] hush: Fix bogus free() call

An off-by-one error in hush.c resulted in an unintentional free() call every time a command was executed
Signed-off-by: Peter Tyser ptyser@xes-inc.com --- common/hush.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/hush.c b/common/hush.c index 97fd070..528dd25 100644 --- a/common/hush.c +++ b/common/hush.c @@ -2002,7 +2002,7 @@ static int free_pipe(struct pipe *pi, int indent) #ifndef __U_BOOT__ globfree(&child->glob_result); #else - for (a = child->argc;a >= 0;a--) { + for (a = 0; a < child->argc; a++) { free(child->argv[a]); } free(child->argv);

Dear Peter Tyser,
In message 1249507124-22350-1-git-send-email-ptyser@xes-inc.com you wrote:
An off-by-one error in hush.c resulted in an unintentional free() call every time a command was executed
Signed-off-by: Peter Tyser ptyser@xes-inc.com
common/hush.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
participants (2)
-
Peter Tyser
-
Wolfgang Denk