[U-Boot] [PATCH] x86: tangier: Fix pinmux warning

Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe': w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka union ofnode_union}' [-Wformat=]
This fixes it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com ---
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/cpu/tangier/pinmux.c b/arch/x86/cpu/tangier/pinmux.c index bbb3d7b..fdd6530 100644 --- a/arch/x86/cpu/tangier/pinmux.c +++ b/arch/x86/cpu/tangier/pinmux.c @@ -172,8 +172,8 @@ static int tangier_pinctrl_probe(struct udevice *dev) ofnode_for_each_subnode(pin_node, dev_ofnode(dev)) { ret = mrfld_pinctrl_cfg_pin(pin_node); if (ret) { - pr_err("%s: invalid configuration for the pin %d\n", - __func__, pin_node); + pr_err("%s: invalid configuration for the pin %ld\n", + __func__, pin_node.of_offset); } }

Hi Georgii,
On Mon, Sep 17, 2018 at 5:28 PM Bin Meng bmeng.cn@gmail.com wrote:
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe': w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka union ofnode_union}' [-Wformat=]
This fixes it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Regards, Bin

On Mon, Sep 17, 2018 at 05:30:01PM +0800, Bin Meng wrote:
Hi Georgii,
On Mon, Sep 17, 2018 at 5:28 PM Bin Meng bmeng.cn@gmail.com wrote:
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe': w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka union ofnode_union}' [-Wformat=]
This fixes it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Regards, Bin
Hi Bin,
Thanks for taking care of it so fast. Sorry for the trouble. LGTM. Squash it, please.
Regards, Georgii

On Mon, Sep 17, 2018 at 5:35 PM Georgii Staroselskii georgii.staroselskii@emlid.com wrote:
On Mon, Sep 17, 2018 at 05:30:01PM +0800, Bin Meng wrote:
Hi Georgii,
On Mon, Sep 17, 2018 at 5:28 PM Bin Meng bmeng.cn@gmail.com wrote:
Currently the code builds with a warning:
w+../arch/x86/cpu/tangier/pinmux.c: In function 'tangier_pinctrl_probe': w+../arch/x86/cpu/tangier/pinmux.c:175:11: warning: format '%d' expects argument of type 'int', but argument 3 has type 'ofnode {aka union ofnode_union}' [-Wformat=]
This fixes it.
Signed-off-by: Bin Meng bmeng.cn@gmail.com
arch/x86/cpu/tangier/pinmux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Please confirm whether this looks good. If no issue, I will squash this commit into your previous patch [2/5] "x86: tangier: pinmux: add API to configure protected pins"
Regards, Bin
Hi Bin,
Thanks for taking care of it so fast. Sorry for the trouble. LGTM. Squash it, please.
OK, squashed.
Regards, Bin
participants (2)
-
Bin Meng
-
Georgii Staroselskii