Re: [U-Boot] [PATCH] usb_storage: USB storage transfer size increase for xHCI
On Thursday, August 13, 2015 at 10:56:27 PM, Sergei Temerkhanov wrote:
Hi!
(please stop top-posting ; please keep the list in the loop)
Well, when I was working on this, setting large transfer sizes resulted in, AFAIR, xhci_wait_for_event() timeout and changing XHCI_TIMEOUT doesn't help. This function returns NULL which is being dereferenced somewhere else (I don't remember where exactly), there are several places in the generic xhci support code where this is possible.
I suspect we might need a quirk for the XHCI instead them (quirk that the controller gets stuck when you try to queue arbitrary number of descriptors). But I wonder, don't you have some cache problems instead ? Try disabling dcache (CONFIG_SYS_DCACHE_OFF) on your machine and see if that fixes the problem .
Best regards, Marek Vasut
OK, I'll try to find some time for this. I remember trying it with DCACHE disabled but for no luck
Regards, Sergey
On Fri, Aug 14, 2015 at 1:42 AM, Marek Vasut marex@denx.de wrote:
On Thursday, August 13, 2015 at 10:56:27 PM, Sergei Temerkhanov wrote:
Hi!
(please stop top-posting ; please keep the list in the loop)
Well, when I was working on this, setting large transfer sizes resulted
in,
AFAIR, xhci_wait_for_event() timeout and changing XHCI_TIMEOUT doesn't help. This function returns NULL which is being dereferenced somewhere
else
(I don't remember where exactly), there are several places in the generic xhci support code where this is possible.
I suspect we might need a quirk for the XHCI instead them (quirk that the controller gets stuck when you try to queue arbitrary number of descriptors). But I wonder, don't you have some cache problems instead ? Try disabling dcache (CONFIG_SYS_DCACHE_OFF) on your machine and see if that fixes the problem .
Best regards, Marek Vasut
On Friday, August 14, 2015 at 02:09:50 PM, Sergei Temerkhanov wrote:
OK, I'll try to find some time for this. I remember trying it with DCACHE disabled but for no luck
Cool, thanks. Btw please stop top-posting ;)
Regards, Sergey
On Fri, Aug 14, 2015 at 1:42 AM, Marek Vasut marex@denx.de wrote:
On Thursday, August 13, 2015 at 10:56:27 PM, Sergei Temerkhanov wrote:
Hi!
(please stop top-posting ; please keep the list in the loop)
Well, when I was working on this, setting large transfer sizes resulted
in,
AFAIR, xhci_wait_for_event() timeout and changing XHCI_TIMEOUT doesn't help. This function returns NULL which is being dereferenced somewhere
else
(I don't remember where exactly), there are several places in the generic xhci support code where this is possible.
I suspect we might need a quirk for the XHCI instead them (quirk that the controller gets stuck when you try to queue arbitrary number of descriptors). But I wonder, don't you have some cache problems instead ? Try disabling dcache (CONFIG_SYS_DCACHE_OFF) on your machine and see if that fixes the problem .
Best regards, Marek Vasut
Best regards, Marek Vasut
participants (2)
-
Marek Vasut -
Sergei Temerkhanov