BUG: pta_scp03_invoke_func() in drivers/tee/sandbox.c
Hello Simon,
could you, please, have a look at this warning:
drivers/tee/sandbox.c: In function ‘pta_scp03_invoke_func’: drivers/tee/sandbox.c:138:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 138 | if (params[0].u.value.a) | ^ drivers/tee/sandbox.c:141:9: note: here 141 | default: | ^~~~~~~
Either the return statement is incorrectly indented and a fallthrough macro is missing or the if statement is superfluous.
Best regards
Heinrich
Hi Heinrich,
On Sat, 1 Apr 2023 at 20:58, Heinrich Schuchardt < heinrich.schuchardt@canonical.com> wrote:
Hello Simon,
could you, please, have a look at this warning:
drivers/tee/sandbox.c: In function ‘pta_scp03_invoke_func’: drivers/tee/sandbox.c:138:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 138 | if (params[0].u.value.a) | ^ drivers/tee/sandbox.c:141:9: note: here 141 | default: | ^~~~~~~
Either the return statement is incorrectly indented and a fallthrough macro is missing or the if statement is superfluous.
+Jorge Ramirez who will know.
Regards, SImon
Best regards
Heinrich
sorry i am out of the office for a couple of days but that commit looks horrible. not sure what happened there. i'll propose something before thursday.
On 2 Apr 2023, at 04:41, Simon Glass sjg@chromium.org wrote:
Hi Heinrich,
On Sat, 1 Apr 2023 at 20:58, Heinrich Schuchardt < heinrich.schuchardt@canonical.com> wrote:
Hello Simon,
could you, please, have a look at this warning:
drivers/tee/sandbox.c: In function ‘pta_scp03_invoke_func’: drivers/tee/sandbox.c:138:20: warning: this statement may fall through [-Wimplicit-fallthrough=] 138 | if (params[0].u.value.a) | ^ drivers/tee/sandbox.c:141:9: note: here 141 | default: | ^~~~~~~
Either the return statement is incorrectly indented and a fallthrough macro is missing or the if statement is superfluous.
+Jorge Ramirez who will know.
Regards, SImon
Best regards
Heinrich
participants (3)
-
Heinrich Schuchardt -
jorge.ramirez.ortiz＠gmail.com -
Simon Glass