
Hi,
On 3/28/24 10:01, lukas.funke-oss@weidmueller.com wrote:
From: Lukas Funke lukas.funke@weidmueller.com
This series adds support to enable/disable/lock the jtag interface from u-boot. This becomes handy if secure boot is used but debugging should be poissible for non-productions builds.
The series also adds support to get/set the multiboot register in order to ensure a freash bootimage search after soft reset.
nit: typo here.
I understand what you do and why but completely missing wiring for using it. Likely you are calling it from your code but pretty much when this is applied it is just dead code. Can we wire it up somehow?
1/3 - showing multiboot at boot Then do similar things as are done with SPL_ZYNQMP_ALT_BOOTMODE
2/3 this is pretty much the same what it is done via ZYNQMP_RESTORE_JTAG (also please rename it to be aligned together).
3/3 - I would be fine if this is connected to zynq specific command for example (unlock can be wired like that too).
Thanks, Michal