Re: [PATCH 1/1] net: phy: possible NULL dereference in fixed_phy_create()

On Mon, 11 Jul 2022 19:40:13 +0200 Heinrich Schuchardt heinrich.schuchardt@canonical.com wrote:

We check if phydev is NULL. Only but if it is non-NULL we set one component of phydev. But even if it is NULL we set another. We should not dereference NULL in either case.

Fixes: e24b58f5ed4f ("net: phy: don't require PHY interface mode during PHY creation") Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com

Reviewed-by: Marek Behún kabel@kernel.org