Re: [U-Boot-Users] Fix empty i2c reads/writes in fsl_i2c.c

Joakim Tjernlund wrote:

...

will never call "__i2c_read(data, length)", and so it will never set the value of i. Then it will return, indicating success.

No, i will be 0 and length will be !=0 so no success.

Oh yeah, right.

Yes, I agree. The orginal freescale code looked something like that, but I am not going to rewrite it back to that form. Someone did change it to this form.

Really? That's weird. Oh well. In that case, your patch is okay.