Re: [U-Boot] [PATCH 1/4] sf: Unify spi_flash write code

Hi Jagan,

On Fri, Jun 14, 2013 at 1:18 PM, Jagannadha Sutradharudu Teki < jagannadha.sutradharudu-teki@xilinx.com> wrote:

Move common flash write code into spi_flash_write_common().

Signed-off-by: Jagannadha Sutradharudu Teki jaganna@xilinx.com

drivers/mtd/spi/spi_flash.c | 122 ++++++++++++++++------------------- drivers/mtd/spi/spi_flash_internal.h | 6 ++ 2 files changed, 60 insertions(+), 68 deletions(-)

This looks good except that spi_flash_write_common() is not a great name - only one of the operations is a 'write'. Perhaps spi_flash_oper_common() or similar?

Regards, Simon