On 14:41 Sat 02 May , Prafulla Wadaskar wrote:
Thanks Jean for your review...
diff --git a/cpu/arm926ejs/kirkwood/kwcore.c b/cpu/arm926ejs/kirkwood/kwcore.c new file mode 100644 index 0000000..9eaaab6 --- /dev/null +++ b/cpu/arm926ejs/kirkwood/kwcore.c
please cpu.c
Okay I will rename it
*/ -#ifndef CONFIG_SKIP_LOWLEVEL_INIT +#if !defined (CONFIG_SKIP_LOWLEVEL_INIT) || defined +(CONFIG_ARCH_LOWLEVEL_INIT)
NACK
if you skip the lowlevel init you also skip the arch lowlevel_init
I got it already, I have encapsulated similar condition at caller function so that even though only ARCH_LOWLEVEL_INIT is define it will not skip it.
if it's permannent arch init please use arch_cpu_init
Is it really lowlevel init, needs to be called before stack/dram init, so please let it be arch_lowlevel_init. I am trying to keep minimal code under arch_lowlevel_init (only few assembly lines) rest I am moving to arch_cpu_init under lib_arm/board.c
the arch_cpu_init is the first init in c and I want the current design clear If you choice to skip the lowlevel_init you will skip all lowlevel_init with no exception as I've in mind to regroup all start.S
Best Regards, J.