On Monday 16 February 2009 19:16:13 Wolfgang Denk wrote:
In message Mike wrote:
+void load_sernum_ethaddr (void) +{ +}
See previous comments - please do not add dead code just to remove it later.
your previous comment doesnt apply to these later ones. the first change is for arm-only. the later changes are for ppc. it isnt dead code because the function is still called by common ppc code. just like i outlined in the summary for this patchset.
Well, there is a very small number of boards. Why cannot we have this change in one step, in one commit? Adding empty functions just to remove them later seems sub-optimal to me.
in my mind, what i did is more logical. i'll do whatever way you want though. so just explicitly state "squash those changes into one even though they touch a bunch of different places" and i'll happily do it. -mike