Re: [U-Boot] Breakage on arm/next

On Mon, Dec 21, 2009 at 04:30:40PM +0530, apgmoorthy wrote:

Hunk 1: env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);

Hunk 2: env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);

I'd say it should be the board config file's responsibility to provide a CONFIG_ENV_ADDR that is properly block-aligned, regardless of what sort of flash it's using.

instr.len = onenand_mtd.eraseregions[0].erasesize;

It's unlikely at these block sizes, but theoretically the environment could span multiple erase blocks.

Again, the board config file should supply a suitable CONFIG_ENV_SIZE.

-Scott