Hello Mike,
Mike Frysinger wrote:
On Wednesday, June 01, 2011 02:54:30 Heiko Schocher wrote:
Wolfgang Denk wrote:
Heiko Schocher wrote:
--- a/post/drivers/memory.c +++ b/post/drivers/memory.c @@ -455,10 +455,30 @@ static int memory_post_tests (unsigned long start, unsigned long size)
__attribute__((weak)) int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset) {
+#if defined(CONFIG_ARM)
This is a weak function, so there should be no need to have #ifdef's in there.
Just define your own code as you need it.
Yes (I did this for my case, as I use it in nand_spl code, and therefore I need a "own" function, because there I have no bd ) ... but, for arm there is no bd->bi_memsize! ... so this file fails compiling. Independent, if it gets replaced by another function.
so add bi_memsize to arm ? it's the only arch that lacks it.
Hmm.. I thought of that too, but wouldn;t it be better to use gd->ram_size in post/drivers/memory.c, as this is defined in global_data for all archs?
bye, Heiko