On 3 September 2018 at 18:05, Jagdish Gediya jagdish.gediya@nxp.com wrote:
Currently binman calculates '_skip_at_start' based on 'end-at-4gb' property and it is used for x86 images.
For PowerPC mpc85xx based CPU, CONFIG_SYS_TEXT_BASE is the entry offset of the first entry. It can be 0xeff40000 or 0xfff40000 for nor flash boot, 0x201000 for sd boot etc, so "_skip_at_start" should be set to CONFIG_SYS_TEXT_BASE.
'end-at-4gb' property is not applicable where CONFIG_SYS_TEXT_BASE + Image size != 4gb.
Add new property 'skip-at-start' in Section class so that '_skip_at_start' can be calculated either based on 'end-at-4gb' or based on "skip-at-start".
Add a test case to check that 'skip-at-start' and 'end-at-4gb' property can't be used together.
Signed-off-by: Jagdish Gediya jagdish.gediya@nxp.com Reviewed-by: Bin Meng bmeng.cn@gmail.com
Changes for v2: - Renamed 'start-pos' property to 'skip-at-start' - Updated README
Changes for v3: - Modification as per Simon Glass's comments - Added test case for 'skip-at-start' property
tools/binman/README | 9 +++++++++ tools/binman/bsection.py | 15 +++++++++++---- tools/binman/ftest.py | 8 ++++++++ .../test/80_4gb_and_skip_at_start_together.dts | 21 +++++++++++++++++++++ 4 files changed, 49 insertions(+), 4 deletions(-) create mode 100644 tools/binman/test/80_4gb_and_skip_at_start_together.dts
Reviewed-by: Simon Glass sjg@chromium.org