HI Magnus Lilja: Best Regards Fred
2009/9/23, Magnus Lilja lilja.magnus@gmail.com:
Hmm, for some reason "Reply" in gmail cut part of the qouted message so here's the rest of the followup.
Fred Fan skrev:
Hi Magnus Liljia: Thanks for your comments. Best Regards Fred
2009/9/22, Magnus Lilja lilja.magnus@gmail.com:
Hi
I've scanned the patch briefly and have some comments below.
gareatech@gmail.com wrote: I don't think everything in this file is needed by U-Boot, e.g. the interrupt definitions. Yes. But interrupt maybe use when interrupt is supportted. Do I need
remove
the definitions which are not used?
Don't know. We have plan to support interrupt in furture.
diff --git a/include/configs/imx51.h b/include/configs/imx51.h
new file mode 100644 index 0000000..f0def4e --- /dev/null +++ b/include/configs/imx51.h @@ -0,0 +1,177 @@ +/*
- Copyright (C) 2007, Guennadi Liakhovetski lg@denx.de
- (C) Copyright 2009 Freescale Semiconductor, Inc.
- Configuration settings for the MX51-3Stack Freescale board.
- This program is free software; you can redistribute it and/or
- modify it under the terms of the GNU General Public License as
- published by the Free Software Foundation; either version 2 of
- the License, or (at your option) any later version.
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston,
- MA 02111-1307 USA
- */
+#ifndef __CONFIG_H +#define __CONFIG_H
+#include <asm/arch/mx51.h>
- /* High Level Configuration Options */
+#define CONFIG_ARMV7 1 /* This is armv7 Cortex-A8 CPU
core
*/
+#define CONFIG_L2_OFF
+#define CONFIG_MXC 1 +#define CONFIG_MX51_BBG 1 /* in a mx51 */
Can't see that this is used anywhere. OK. I will remove them;
Only remove MX51_BBG, I didn't check if CONFIG_MXC is used anywhere. OK.
Regards, Magnus