Hello Eugen,
Am 12.04.2019 um 15:52 schrieb Heiko Schocher:
Hello Eugen,
Am 12.04.2019 um 15:07 schrieb Eugen.Hristev@microchip.com:
On 12.04.2019 15:53, Heiko Schocher wrote:
External E-Mail
Hello eugen,
Am 12.04.2019 um 13:24 schrieb Eugen.Hristev@microchip.com:
On 11.04.2019 08:53, Heiko Schocher wrote:
- at91sam9g20-taurus.dts: use labels
- cleanup taurus port to compile clean with
current mainline again. SPL has no serial output anymore, so it fits into SRAM.
Signed-off-by: Heiko Schocher hs@denx.de
[snip]
Hello Heiko,
This patch has several issues:
taurus_defconfig
+spl/dts/dt-platdata.c:11:46: error: missing braces around initializer [-Werror=missing-braces]
- static const struct dtd_simple_bus dtv_ahb = {
+ ^ +spl/dts/dt-platdata.c:20:46: error: missing braces around initializer [-Werror=missing-braces]
- static const struct dtd_simple_bus dtv_apb = {
+cc1: all warnings being treated as errors +make[2]: *** [spl/dts/dt-platdata.o] Error 1 +make[1]: *** [spl/u-boot-spl] Error 2 +make: *** [sub-make] Error 2
Ah, I had not warnings as errors active ... sorry for this!
Hmmm:
in generated ./include/generated/dt-structs-gen.h
struct dtd_simple_bus { bool ranges; };
True but at line #44 you have
#define dtd_simple_bus dtd_atmel_at91rm9200_pinctrl
Which redefines things...
indeed. As this is an autmatic generated file, I must look deeper into it!
Hmm... following wip patch solves the warning:
$ git diff diff --git a/arch/arm/dts/at91sam9260.dtsi b/arch/arm/dts/at91sam9260.dtsi index 800d96eb2f..551364513f 100644 --- a/arch/arm/dts/at91sam9260.dtsi +++ b/arch/arm/dts/at91sam9260.dtsi @@ -440,7 +440,7 @@ pinctrl: pinctrl@fffff400 { #address-cells = <1>; #size-cells = <1>; - compatible = "atmel,at91rm9200-pinctrl", "simple-bus"; + compatible = "atmel,at91rm9200-pinctrl"; ranges = <0xfffff400 0xfffff400 0x600>; reg = <0xfffff400 0x200 /* pioA */ 0xfffff600 0x200 /* pioB */ $
This prevents that the line with:
#define dtd_simple_bus dtd_atmel_at91rm9200_pinctrl
gets created, but I wonder why other boards do not have this warning.
bye, Heiko
bye, Heiko
and in spl/dts/dt-platdata.c:
#include <dt-structs.h>
static const struct dtd_simple_bus dtv_ahb = { .ranges = true, };
Do not see what is really wrong ... may friday afternoon ...
and axm_defconfig :
+drivers/built-in.o: In function `get_current': +drivers/serial/serial.c:318: undefined reference to `default_serial_console' +make[2]: *** [spl/u-boot-spl] Error 1 +make[1]: *** [spl/u-boot-spl] Error 2 +make: *** [sub-make] Error 2
Ups, sorry, just forgot to add this, update this in v2.
Thanks for the review!
bye, Heiko